Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [bugfix-2.0] Ramps and Viki LCD not compiling #15765

Closed
chepo92 opened this issue Nov 2, 2019 · 4 comments
Closed

[BUG] [bugfix-2.0] Ramps and Viki LCD not compiling #15765

chepo92 opened this issue Nov 2, 2019 · 4 comments

Comments

@chepo92
Copy link
Contributor

chepo92 commented Nov 2, 2019

Description

I'm trying to compile marlin 2 with RAMPS and viki 1 LCD (i2c), i'm on the way of resolving this but I need to move some include libraries, so need some advice

In file included from C:\Users\Axel\AppData\Local\Temp\arduino_build_755273\sketch\src\module\configuration_store.cpp:53:0:

c:\users\axel\appdata\local\temp\arduino_build_755273\sketch\src\lcd\ultralcd.h: In static member function 'static bool MarlinUI::button_pressed()':

c:\users\axel\appdata\local\temp\arduino_build_755273\sketch\src\lcd\ultralcd.h:161:19: error: 'BUTTON_SELECT' was not declared in this scope

 #define B_MI (BUTTON_SELECT << B_I2C_BTN_OFFSET)

After moving the include libraries from ultralcd_HD44780.h line 67 to Conditionals_LCD.h line 273 and adding some missing conditionals for heat bed i get this:

C:\Users\Axel\AppData\Local\Temp\arduino_build_345136\sketch\src\lcd\ultralcd.cpp:71:7: error: 'lcd' was not declared in this scope

   lcd.buzz(duration, freq);

Steps to Reproduce

  1. Uncomment line ~1835 #define LCD_I2C_VIKI
  2. Compile
  3. Get the first bug
  4. Move include libs
  5. Get the second bug

Expected behavior: Compile successful

Actual behavior: get some bugs

Additional Information

LCD is working with 1.1 bugfix

bug catching in: https://github.com/chepo92/Marlin/tree/vikiLCD-bugfix-2.0

@chepo92
Copy link
Contributor Author

chepo92 commented Nov 2, 2019

This is similar to #14812 , so Tried https://github.com/Ludy87/Marlin/tree/bf2_buzzer2 after compiling it successful for panelolu, changed to Viki aption got another bug, solved moving the libraries include

#include <Wire.h>
#include <LiquidTWI2.h>

to ultralcd.h , now it throws:

C:\Users\Axel\AppData\Local\Temp\arduino_build_811531\sketch\src\lcd\HD44780\ultralcd_HD44780.cpp:390:62: error: 'next_button_update_ms' was not declared in this scope

     if ((slow_bits & (B_MI | B_RI)) && PENDING(millis(), next_button_update_ms)) // LCD clicked
                                                          ^

@boelle
Copy link
Contributor

boelle commented Nov 3, 2019

Configurations, please
Please ZIP up your Configuration.h and Configuration_adv.h files (as
requested in the Issue template) and drop them into your next reply.
We'll check them over and see if anything is amiss.

@chepo92
Copy link
Contributor Author

chepo92 commented Nov 3, 2019

Configs.zip

This was referenced Nov 3, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants