Viki 1.0 LCD #15811
Merged
Viki 1.0 LCD #15811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
reviewed
Nov 6, 2019
Co-Authored-By: chepo92 <ansepulveda@uc.cl>
Co-Authored-By: chepo92 <ansepulveda@uc.cl>
thinkyhead
force-pushed
the
bf_buzzer2_viki
branch
from
f998c0d to
46e9844
Compare
philippniethammer
pushed a commit
to philippniethammer/Marlin
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added conditionals led status when heat bed no enabled (throwed errors)
Changes pin definition for ramps when Viki I2C enabled (to match official wiring diagram)
Tested with ramps and Viki 1.0 hardware
Benefits
solves compiling issues for viki 1 LCD I2C using Ramps board
Related Issues
fixes:
#15765 (tested working)