Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix from #17770 breaks compiling with AUTO_BED_LEVELING_BILINEAR #18545

Closed
Masanetz opened this issue Jul 5, 2020 · 10 comments
Closed

Comments

@Masanetz
Copy link

Masanetz commented Jul 5, 2020

The fix from #17770 seems to break compiling with AUTO_BED_LEVELING_BILINEAR, as abl_points nether declared nor has it a value...
Maybe the comment in line 248 of G29.cpp is somewhat misleading:
#elif ENABLED(PROBE_MANUALLY) // Bilinear
changed to
#elif EITHER(PROBE_MANUALLY, AUTO_BED_LEVELING_BILINEAR) // Bilinear
it compiled again...

In file included from Marlin/src/gcode/bedlevel/abl/../../../inc/MarlinConfig.h:47:0,
from Marlin/src/gcode/bedlevel/abl/G29.cpp:27:
Marlin/src/gcode/bedlevel/abl/G29.cpp: In static member function 'static void GcodeSuite::G29()':
Marlin/src/gcode/bedlevel/abl/G29.cpp:646:91: error: 'abl_points' was not declared in this scope
if (verbose_level) SERIAL_ECHOLNPAIR("Probing mesh point ", int(pt_index), "/", abl_points, ".");
^
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:111:57: note: in definition of macro '_SEP_2'
#define _SEP_2(PRE,V) serial_echopair_PGM(PSTR(PRE),V)
^
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:174:45: note: in expansion of macro '_SELP_3'
#define _SELP_5(a,b,V...) do{ _SEP_2(a,b); _SELP_3(V); }while(0)
^~~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:168:28: note: in expansion of macro '_SELP_5'
#define __SELP_N(N,V...) SELP##N(V)
^~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:169:28: note: in expansion of macro '__SELP_N'
#define _SELP_N(N,V...) __SELP_N(N,V)
^~~~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:201:33: note: in expansion of macro '_SELP_N'
#define SERIAL_ECHOLNPAIR(V...) _SELP_N(NUM_ARGS(V),V)
^~~~~~~
Marlin/src/gcode/bedlevel/abl/G29.cpp:646:30: note: in expansion of macro 'SERIAL_ECHOLNPAIR'
if (verbose_level) SERIAL_ECHOLNPAIR("Probing mesh point ", int(pt_index), "/", abl_points, ".");
^~~~~~~~~~~~~~~~~
Marlin/src/gcode/bedlevel/abl/G29.cpp:646:91: note: suggested alternative: 'abc_pos_t'
if (verbose_level) SERIAL_ECHOLNPAIR("Probing mesh point ", int(pt_index), "/", abl_points, ".");
^
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:111:57: note: in definition of macro '_SEP_2'
#define _SEP_2(PRE,V) serial_echopair_PGM(PSTR(PRE),V)
^
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:174:45: note: in expansion of macro '_SELP_3'
#define _SELP_5(a,b,V...) do{ _SEP_2(a,b); _SELP_3(V); }while(0)
^~~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:168:28: note: in expansion of macro '_SELP_5'
#define __SELP_N(N,V...) SELP##N(V)
^~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:169:28: note: in expansion of macro '__SELP_N'
#define _SELP_N(N,V...) __SELP_N(N,V)
^~~~~~~~
Marlin/src/gcode/bedlevel/abl/../../../inc/../core/serial.h:201:33: note: in expansion of macro '_SELP_N'
#define SERIAL_ECHOLNPAIR(V...) _SELP_N(NUM_ARGS(V),V)
^~~~~~~
Marlin/src/gcode/bedlevel/abl/G29.cpp:646:30: note: in expansion of macro 'SERIAL_ECHOLNPAIR'
if (verbose_level) SERIAL_ECHOLNPAIR("Probing mesh point ", int(pt_index), "/", abl_points, ".");
^~~~~~~~~~~~~~~~~
*** [.pio/build/chitu_v5_gpio_init/src/src/gcode/bedlevel/abl/G29.cpp.o] Error 1
@thisiskeithb
Copy link
Member

Please download bugfix-2.0.x to test with the latest code and let us know if you're still having this issue.

Also: Please follow the Issue Template when filing a bug report:

<!--

Have you read Marlin's Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/.github/code_of_conduct.md

Do you want to ask a question? Are you looking for support? Please don't post here. Instead please use the Marlin Firmware forum at http://forums.reprap.org/list.php?415 or the Marlin Facebook Group https://www.facebook.com/groups/1049718498464482/ or the Marlin Discord Server https://discord.gg/n5NJ59y.

Before filing an issue be sure to test the 1.1 and/or 2.0 "bugfix" branches to see whether the issue is already addressed.

-->

### Description

<!-- Description of the bug or requested feature -->

### Steps to Reproduce

<!-- If this is a Bug Report, please describe the steps needed to reproduce the issue -->

1. [First Step]
2. [Second Step]
3. [and so on...]

**Expected behavior:** [What you expect to happen]

**Actual behavior:** [What actually happens]

#### Additional Information

* Include a ZIP file containing your `Configuration.h` and `Configuration_adv.h` files.
* Provide pictures or links to videos that clearly demonstrate the issue.
* See [How Can I Contribute](#how-can-i-contribute) for additional guidelines.

@RemcoPerlee
Copy link

I did a different fix to get it to compile. I replaced "abl_points" to "int(GRID_MAX_POINTS)" on line 646

@RemcoPerlee
Copy link

I was using the file that is currently on GitHub (checked just a sec ago)

@ellensp
Copy link
Contributor

ellensp commented Jul 5, 2020

That is latest bugfix. It got broken 4 hours ago on bugfix only. ea520e6

thisiskeithb referenced this issue Jul 5, 2020
Closes #17770

Co-Authored-By: Jan-Gerard van der Toorn <jan-gerard@users.noreply.github.com>
@thisiskeithb
Copy link
Member

That is latest bugfix. It got broken 4 hours ago on bugfix only. ea520e6

Bug confirmed.

@TheGadge
Copy link

TheGadge commented Jul 5, 2020

Thanks for this post, was going insane. I can compile fine without AUTO_BED_LEVELING_BILINEAR,
SKR mini e3 2. Is there any 'fix' we can do ourselves for this please?

Edit: Thanks to someone in the fix note; (NAPCAL)

Only for debugging adding this code at the blank line (234) int constexpr abl_points = GRID_MAX_POINTS; // ADDED FOR DEBUG TAW
and the error doesn't show and fully compiles.

@qwewer0
Copy link
Contributor

qwewer0 commented Jul 5, 2020

(234) int constexpr abl_points = GRID_MAX_POINTS; // ADDED FOR DEBUG TAW

With this fix, it compiles for me.
(Without the fix)

oliver-eifler added a commit to oliver-eifler/Marlin-Olli that referenced this issue Jul 5, 2020
Fixes "Fix from MarlinFirmware#17770 breaks compiling with AUTO_BED_LEVELING_BILINEAR MarlinFirmware#18545"
@qwewer0
Copy link
Contributor

qwewer0 commented Jul 5, 2020

Fixed with #18552

@sjasonsmith
Copy link
Contributor

I can confirm that it is now fixed for me as well.

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants