-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix from #17770 breaks compiling with AUTO_BED_LEVELING_BILINEAR #18545
Comments
Please download Also: Please follow the Issue Template when filing a bug report: <!--
Have you read Marlin's Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/.github/code_of_conduct.md
Do you want to ask a question? Are you looking for support? Please don't post here. Instead please use the Marlin Firmware forum at http://forums.reprap.org/list.php?415 or the Marlin Facebook Group https://www.facebook.com/groups/1049718498464482/ or the Marlin Discord Server https://discord.gg/n5NJ59y.
Before filing an issue be sure to test the 1.1 and/or 2.0 "bugfix" branches to see whether the issue is already addressed.
-->
### Description
<!-- Description of the bug or requested feature -->
### Steps to Reproduce
<!-- If this is a Bug Report, please describe the steps needed to reproduce the issue -->
1. [First Step]
2. [Second Step]
3. [and so on...]
**Expected behavior:** [What you expect to happen]
**Actual behavior:** [What actually happens]
#### Additional Information
* Include a ZIP file containing your `Configuration.h` and `Configuration_adv.h` files.
* Provide pictures or links to videos that clearly demonstrate the issue.
* See [How Can I Contribute](#how-can-i-contribute) for additional guidelines. |
I did a different fix to get it to compile. I replaced "abl_points" to "int(GRID_MAX_POINTS)" on line 646 |
I was using the file that is currently on GitHub (checked just a sec ago) |
That is latest bugfix. It got broken 4 hours ago on bugfix only. ea520e6 |
Closes #17770 Co-Authored-By: Jan-Gerard van der Toorn <jan-gerard@users.noreply.github.com>
Bug confirmed. |
Thanks for this post, was going insane. I can compile fine without AUTO_BED_LEVELING_BILINEAR, Edit: Thanks to someone in the fix note; (NAPCAL)
|
With this fix, it compiles for me. |
Fixes "Fix from MarlinFirmware#17770 breaks compiling with AUTO_BED_LEVELING_BILINEAR MarlinFirmware#18545"
Fixed with #18552 |
I can confirm that it is now fixed for me as well. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The fix from #17770 seems to break compiling with AUTO_BED_LEVELING_BILINEAR, as abl_points nether declared nor has it a value...
Maybe the comment in line 248 of G29.cpp is somewhat misleading:
#elif ENABLED(PROBE_MANUALLY) // Bilinear
changed to
#elif EITHER(PROBE_MANUALLY, AUTO_BED_LEVELING_BILINEAR) // Bilinear
it compiled again...
The text was updated successfully, but these errors were encountered: