Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cr10s screen overlapped #19350

Closed
Liger0 opened this issue Sep 11, 2020 · 9 comments
Closed

[BUG] cr10s screen overlapped #19350

Liger0 opened this issue Sep 11, 2020 · 9 comments

Comments

@Liger0
Copy link

Liger0 commented Sep 11, 2020

Bug Description

The text overlap the values on 2.0.6.1

My Configurations

Marlin.zip

Steps to Reproduce

  1. Go in a configuration

Expected behavior: Text are separate from the values

Actual behavior: Text hides the values

Additional Information

text marlin 2 0 6 1 cr10s

@boelle
Copy link
Contributor

boelle commented Sep 11, 2020

Please test the bugfix-2.0.x branch to see where it stands.

@Liger0
Copy link
Author

Liger0 commented Sep 11, 2020

Do you mean to test on latest bugfix or to test the stable releases?

@ellensp
Copy link
Contributor

ellensp commented Sep 12, 2020

Checked on current bugfix.

@ellensp
Copy link
Contributor

ellensp commented Sep 12, 2020

Something to do with how the wildcard in MSG_EN_STEPS = _UxGT("* Steps/mm"); is interpreted.
instead of resulting in "E1 Steps/mm" Its resulting in "E1 Steps/mm Steps/mm"
You cant see it on the steps/mm screen but you see it when you edit the value..

@ellensp
Copy link
Contributor

ellensp commented Sep 12, 2020

removing line 60 from https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.0.x/Marlin/src/lcd/lcdprint.cpp#L60
Fixes it. Trying to work out what this line was meant to do and if removing it causes any further issues.

@ellensp
Copy link
Contributor

ellensp commented Sep 12, 2020

Ok line 60 prints while checking the text isn't larger than the lcd. vs default which doesn't..
So adding a break is a better option.

@ellensp
Copy link
Contributor

ellensp commented Sep 12, 2020

Check the PR above (#19351) works for you also.

@ellensp
Copy link
Contributor

ellensp commented Sep 13, 2020

This has been fixed in current bugfix

@ellensp ellensp closed this as completed Sep 13, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants