Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve backoff feedrates #15300

Merged

Conversation

sjasonsmith
Copy link
Contributor

Requirements

  • Filling out this template is required. Pull Requests without a clear description may be closed at the maintainers' discretion.

Description

Consistently use the homing feedrate for each axis when performing endstop backoff moves.
When HOMING_Z_WITH_PROBE is true, this will use Z_PROBE_SPEED_FAST for the feedrate.

Benefits

This resolves three existing problems:

  1. HOMING_BACKOFF_MM may be used without defining Z_PROBE_SPEED_FAST.
  2. Z_PROBE_SPEED_FAST is defined in mm/m, but it was used in a call expecting mm/s, resulting in faster than intended backoff moves.
  3. Z_PROBE_SPEED_FAST was used for all axis. When the mm/m to mm/s problem is fixed, large X/Y backoffs become unnecessarily slow.

This may introduce one problem:

  1. Pull request Adjust homing backoff feedrate #14972 from @InsanityAutomation indicated that higher backoff speeds were needed for BLTouch HS mode. This change will make the backoff slower, because it was previously backing off at 60 times the configured fast probe speed (which probably effectively made it use the axis max speed). Additional changes would be needed if Z_PROBE_SPEED_FAST is not fast enough.

One alternative would be to use the max feed rate for each axis for the backoff moves. I worry there could be a lot of machines configured with incorrect max feedrates. It would work fine if the slicer never exceeds the machine capabilities, but might cause an influx of issues if homing stops working for some people.

Related Issues

#14972 (Prior change which this replaces)
#15221

@thinkyhead thinkyhead merged commit 252f31b into MarlinFirmware:bugfix-2.0.x Sep 18, 2019
@thinkyhead thinkyhead changed the title Use homing and Z probe fast feedrates for endstop backoff Fix/improve backoff feedrates Sep 18, 2019
@sjasonsmith sjasonsmith deleted the 15221_homing_backoff branch September 19, 2019 06:57
markus-seidl pushed a commit to markus-seidl/Marlin that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants