-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.x] Polish language UTF8 #16141
[1.1.x] Polish language UTF8 #16141
Conversation
Polish language in UTF8. It's based on English file. Need some "polishing" but it's good base to start.
you need to push to MarlinFirmware:bugfix-2.0.x instead |
@ArturNadolski — |
My bad. I switched the files while uploading. |
Uploading correct file
i changed the base to bugfix 2.0.x instead of bugfix 1.1.x |
no, i think 1.1.x one was broken :p |
yes but as i understand we only accept PR's to 2.0.x and not 1.1.x |
i think all is utf8 in 2.x |
yes but i still think PR's should be sent to bugfix 2.0.x and not 2.0 2.0 is just selected default if you dont make a selection |
look at all other PR's they go to bugfix 2.0.x |
the 2 is ok imo, its just the 1.1 branch file is not properly encoded as utf8 |
M1.1 is still used by many ppl and my update is for this version. |
but not updated anymore, 2.0.x is the way forward |
hurry up, 2.0.1 is planned this evening... i think ;) passed the afternoon on french review |
yep, that is what i read on discord, but let's see, there is a bit of timezone difference between europe and US of A |
the consensus of the maintainers is that we aren't currently actively working on 1.x anymore, but anyone is still free to do so and submit a fix for a bug or even feature so should this be changed back to 1.1.x ? |
I didn't test it on 2.0 but I just take a look at source and there is Polish translation (I already commit file and pulled request some time ago). At 1.1 brach current Polish translation is very limited and there is no UTF8. |
done and sorry for the confusion, is the polish in 2.0.x ok? |
I think so. Maybe not 100% complete but very close. |
@boelle
He also change title to address specifically 1.1.x:
so he is aware that this was for 1.1.x. I suspect there is an issue on 1.1.x that he likes to be fixed. Maybe this fix may be an exception applied to bugfix-1.x release |
Yes. I consider the lack of proper UTF8 support for Polish a "missing piece" in the 1.1.x tree, and this PR is an obvious patch to deal with that deficit. So it is exactly the kind of patch I am personally happy to accept for the One less unwelcome surprise for Polish users of the 1.1.x patch pile. In general: Anything that fills in a"missing piece" and doesn't alter the feature-set or config methodology of 1.1.x is acceptable as a patch for the bugfix branch. |
[1.1.x] Polish language UTF8 (MarlinFirmware#16141)
* MarlinFirmware/1.1.x: (133 commits) Fix Z position after ABL bilinear G29 with fade (MarlinFirmware#17174) Change DUMMY_PID_VALUE to NAN (MarlinFirmware#17079) Disable integration testing Enable DUAL_NOZZLE_DUPLICATION_MODE (MarlinFirmware#16436) [1.1.x] Polish language UTF8 (MarlinFirmware#16141) Links for the "New Issue" page Add Korean language (MarlinFirmware#15918) [1.1.x] MKS_GEN_L_V2 controller (MarlinFirmware#15805) Update bug_report.md [1.1.x] Fix autostart w/out SD_DETECT_PIN (MarlinFirmware#15667) [1.1.x] RAMPS + Viki1 LCD compatibility (MarlinFirmware#15736) [1.1.x] Fix compiler warning (MarlinFirmware#15642) [1.1.x] Fix for G2/G3 rounding error (MarlinFirmware#15546) Let MINIPANEL use SW SPI if needed (MarlinFirmware#15246) Fix BLTouch debugging (MarlinFirmware#15232) Fix Creality bed thermistor Fix PT-BR strings (MarlinFirmware#15023) Fix #else extra tokens (MarlinFirmware#15013) [1.1.x] Autobuild formatting (MarlinFirmware#14858) [1.1.x] BLTouch 3.0 - 3.1 (MarlinFirmware#14839) ...
Polish language in UTF8. It's based on English file so up-2-date
It has a lot more sentences translated then old version.
Need some "polishing" but it's good base to start.