-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring DGUS screens code #17142
Conversation
a60a7ea
to
5ddc11f
Compare
I've done a rebase and squash to resolve conflicts. I merged the "DUGS" / "DGUS" patch earlier so that we can focus on the other changes here. To update your working copy use the Git console and type the following commands:
|
5ddc11f
to
cb7585a
Compare
Isolate the rename part of MarlinFirmware#17142.
Co-Authored-By: Desuuuu <contact@desuuuu.com>
cb7585a
to
2dee328
Compare
I will check. Give me some time. |
I added a few useful functions for the screen in my last commit. They're documented in the T5UID1 guide (there's a copy available here). |
Compilation not finished , link errors happened . But not the DGUS code part cause this. Maybe my pio or vscode cause that. I need time to check . It can't find <Servo.h> file for me. Weird. I am testing FYSETC S6 . Or you can try to compile to see if it's only my issue. |
Compilation succeeds for me on the latest version of this branch with the example FYSETC S6 (with Do you have anything special in your configuration? |
Forget about the compilation. My git cause issue .And i check and test with S6 board. I think the code is good. |
These functions enable/disable touch controls dynamically.
I added two more functions to control the state of touch controls. It can be useful for example when you have a touch control with a click sound over a button that can be disabled/hidden. |
39fe6ef
to
7aed32d
Compare
7b92348
to
37176ed
Compare
I have been waiting for this for a long time. This was the last piece in fully upgrading A creatbot to Marlin 2.0. What DGUS interface do we use? ADVi3++? |
Nul characters sometimes cause issues with GBK (2-byte) encoding.
The DGUS code has been significantly restructured, so the changes in this PR will need to be reexamined in light of the latest code. It might be a bit of a manual process, but it would be good to know what we have covered already versus what gaps this PR still fills in. |
I do think that's the best way to go. The current DGUS code would probably benefit from some re-organization at least (which was the point of this PR pretty much). I'm not really working on this anymore though so if anyone wants to pick this up, feel free to do so. If there's a need for this, I might pick it up later, provided I find the time and motivation. |
Description
This PR aims to tidy up DGUS code by re-arranging and refactoring it.
Here are the main changes:
VPHELPER
defines which were calling sizeof on pointers. As a result, I re-added the size check inDGUSDisplay::ProcessRx
.Functionality should be unchanged after these changes.
@GerogeFu maybe you could take a look at this considering you've been working on this code recently.