Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pin based on if bltouch enabled #17176

Closed
wants to merge 2 commits into from

Conversation

Vertabreak
Copy link
Contributor

@Vertabreak Vertabreak commented Mar 16, 2020

solve the issue between bltouch and fixed mounted probe pin assignment.
#17063

@Vertabreak
Copy link
Contributor Author

now it should fully cover the issue.

Comment on lines 81 to 94
#elif ENABLED (BLTOUCH)
#define Z_STOP_PIN P1_27 // Z-STOP
#else
#define Z_STOP_PIN P0_10 // Z-STOP
#endif

//
// Z Probe (when not Z_MIN_PIN)
//
#ifndef Z_MIN_PROBE_PIN
#if Z_STOP_PIN != P1_27
#if ENABLED (BLTOUCH)
#define Z_MIN_PROBE_PIN P1_27
#else
#define Z_MIN_PROBE_PIN P0_10
#endif
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if BLtouch is enabled both Z_STOP_PIN and Z_MIN_PROBE_PIN share the same pin? and maybe DISABLED would make more sense at least to me because my bltouch is plugged into the probe connector that is P0_10

@Glought
Copy link
Contributor

Glought commented Mar 16, 2020

Swapping the pins works for me otherwise it doens't work the way you have the pins set.

#elif ENABLED (BLTOUCH) && ENABLED (Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN)
#define Z_STOP_PIN P0_10 // Z-STOP
#else
#define Z_STOP_PIN P1_27 // Z-STOP
#endif

//
// Z Probe (when not Z_MIN_PIN)
//
#if ENABLED (BLTOUCH) && ENABLED (Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN)
#define Z_MIN_PROBE_PIN P0_10
#else
#define Z_MIN_PROBE_PIN P1_27
#endif

@Vertabreak
Copy link
Contributor Author

further investigation seems to suggest you have modified your setup and marlin generally does not support mods. will defer to thinkyhead to make the call on this.

@Vertabreak Vertabreak closed this Mar 16, 2020
@Vertabreak Vertabreak deleted the PR branch March 16, 2020 03:42
@Glought
Copy link
Contributor

Glought commented Mar 16, 2020

I didn't modify anything else in marlin just that pin file my bltouch is plugged into the SKR 1,4 Bltouch Probe connector aka Pin P0.10 i do have older bltouch smart from late 2017 if that could cause any issue.

@Vertabreak
Copy link
Contributor Author

Vertabreak commented Mar 16, 2020

you cut the pin modding the hardware to make it function in this unsupported way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants