-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set pin based on if bltouch enabled #17176
Conversation
now it should fully cover the issue. |
#elif ENABLED (BLTOUCH) | ||
#define Z_STOP_PIN P1_27 // Z-STOP | ||
#else | ||
#define Z_STOP_PIN P0_10 // Z-STOP | ||
#endif | ||
|
||
// | ||
// Z Probe (when not Z_MIN_PIN) | ||
// | ||
#ifndef Z_MIN_PROBE_PIN | ||
#if Z_STOP_PIN != P1_27 | ||
#if ENABLED (BLTOUCH) | ||
#define Z_MIN_PROBE_PIN P1_27 | ||
#else | ||
#define Z_MIN_PROBE_PIN P0_10 | ||
#endif | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if BLtouch is enabled both Z_STOP_PIN and Z_MIN_PROBE_PIN share the same pin? and maybe DISABLED would make more sense at least to me because my bltouch is plugged into the probe connector that is P0_10
Swapping the pins works for me otherwise it doens't work the way you have the pins set. #elif ENABLED (BLTOUCH) && ENABLED (Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN) // |
further investigation seems to suggest you have modified your setup and marlin generally does not support mods. will defer to thinkyhead to make the call on this. |
I didn't modify anything else in marlin just that pin file my bltouch is plugged into the SKR 1,4 Bltouch Probe connector aka Pin P0.10 i do have older bltouch smart from late 2017 if that could cause any issue. |
you cut the pin modding the hardware to make it function in this unsupported way. |
solve the issue between bltouch and fixed mounted probe pin assignment.
#17063