Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Archim boards; Fix mismatch parens #17825

Conversation

marciot
Copy link
Contributor

@marciot marciot commented May 1, 2020

  • Only use the new SPI wrapper class if the HAL for the board declares CLCD_SPI_BUS
  • This allows the code to compile on SAM boards (and others)
  • Fix mismatched parens that broke compilation
  • Tried to fix dgus and malyan lcds (untested)
  • Got rid of redundant config options

Note to @thinkyhead: please do not refactor away the nearly empty config.h file. The reason I left it there is that for testing, it is possible to move the code out of Marlin and compile it independently. In that case, "config.h" is still valid and is replaced with an independent config file.

- Only use the new SPI wrapper class if the HAL for the board declares CLCD_SPI_BUS
- This allows the code to compile on SAM boards (and others)
- Fix mismatched parens that broke compilation
@thinkyhead thinkyhead merged commit db32af9 into MarlinFirmware:bugfix-2.0.x May 2, 2020
robertmeisner pushed a commit to robert-s-archive/MarlinMyDelta that referenced this pull request May 4, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
@marciot marciot deleted the pr-touch-ui-followup-fixes branch December 7, 2020 01:01
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants