-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix STM32 + SoftwareSerial compile (BTT002) #17831
Fix STM32 + SoftwareSerial compile (BTT002) #17831
Conversation
I'm not positive if my change to the Malyan LCD code is the correct fix for that, I just want to get these checks able to run for my STM32 change. |
Works great here on a BTT002 build. Thanks for the patch! |
I can confirm this PR fixes compiling on the SKR Pro 1.1 and software serial for the TMC 2209's is working as expected. |
It works, SKR Pro, 2209, auto-fan. |
…er, using Marlin's SoftwareSerial
e2e606f
to
f071125
Compare
I rebased this on top of the ExtUI fix, to get it back out of this PR. |
Noice! Force push is encouraged for the PR maintainers. As long as you remember to |
I guess I cut that one a little bit close if you were modifying it as I rebased it. |
Description
Follow-up to earlier commit which allowed STM32 HAL timer values to be overridden in board pins files (#17805).
That change did not work when using SoftwareSerial with TMC drivers, because HAL.cpp required one of the constants which was moved to
timers.cpp
.I have added helper which allows
HAL_init
to set the software serial interrupt priority without having to actually know the priority value.Benefits
Allows
HAL/STM32
builds which use SoftwareSerial.I do not currently have hardware set up to test this myself. I'm hoping that @GhostlyCrowd or @thisiskeithb will be able to try it out, since they both encountered this in the attached issue.
Related Issues
#17823