Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STM32 + SoftwareSerial compile (BTT002) #17831

Merged

Conversation

sjasonsmith
Copy link
Contributor

Description

Follow-up to earlier commit which allowed STM32 HAL timer values to be overridden in board pins files (#17805).

That change did not work when using SoftwareSerial with TMC drivers, because HAL.cpp required one of the constants which was moved to timers.cpp.

I have added helper which allows HAL_init to set the software serial interrupt priority without having to actually know the priority value.

Benefits

Allows HAL/STM32 builds which use SoftwareSerial.

I do not currently have hardware set up to test this myself. I'm hoping that @GhostlyCrowd or @thisiskeithb will be able to try it out, since they both encountered this in the attached issue.

Related Issues

#17823

@sjasonsmith
Copy link
Contributor Author

I'm not positive if my change to the Malyan LCD code is the correct fix for that, I just want to get these checks able to run for my STM32 change.

@thisiskeithb
Copy link
Member

Works great here on a BTT002 build. Thanks for the patch!

@GhostlyCrowd
Copy link
Contributor

I can confirm this PR fixes compiling on the SKR Pro 1.1 and software serial for the TMC 2209's is working as expected.

@Fabi0San
Copy link
Contributor

Fabi0San commented May 2, 2020

It works, SKR Pro, 2209, auto-fan.
Thank you @sjasonsmith

@sjasonsmith sjasonsmith force-pushed the 17823_Fix_STM32_Timers branch from e2e606f to f071125 Compare May 2, 2020 21:17
@sjasonsmith
Copy link
Contributor Author

I rebased this on top of the ExtUI fix, to get it back out of this PR.

@thinkyhead
Copy link
Member

Noice! Force push is encouraged for the PR maintainers. As long as you remember to git merge from origin beforehand, in case someone added a commit or two.

@thinkyhead thinkyhead added A: STM32 F: Trinamic PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs. labels May 2, 2020
@sjasonsmith
Copy link
Contributor Author

Noice! Force push is encouraged for the PR maintainers. As long as you remember to git merge from origin beforehand, in case someone added a commit or two.

I guess I cut that one a little bit close if you were modifying it as I rebased it.

@thinkyhead thinkyhead merged commit 208af8c into MarlinFirmware:bugfix-2.0.x May 2, 2020
@thinkyhead thinkyhead changed the title Fix broken STM32 builds when using TMC 2208/9 drivers Fix STM32 + SoftwareSerial compile (BTT002) May 2, 2020
robertmeisner pushed a commit to robert-s-archive/MarlinMyDelta that referenced this pull request May 4, 2020
@sjasonsmith sjasonsmith deleted the 17823_Fix_STM32_Timers branch May 10, 2020 05:16
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this pull request Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: STM32 F: Trinamic PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants