MARLIN_EEPROM_SIZE with E2END as fallback #18059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf2_eeprom_size_setting_PR
branch
4 times, most recently
from
4c83653 to
87d72e7
Compare
thinkyhead
changed the title
thinkyhead
force-pushed
the
bf2_eeprom_size_setting_PR
branch
4 times, most recently
from
0183d94 to
7c4d78b
Compare
thinkyhead
force-pushed
the
bf2_eeprom_size_setting_PR
branch
from
7c4d78b to
230de98
Compare
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
E2ENDas our primary define for available settings storage space has caveats:E2ENDas the size of the EEPROM.#undef E2ENDto redefine the value, losing the platform value. It takes extra work to tell if the value comes from Marlin or from the platform, and to check that the override was done in the right place, and so on.This PR makes Marlin use
MARLIN_EEPROM_SIZEto specify the total storage available for settings. (The nameEEPROM_SIZEis used by some platforms, so that can't be used if we want it to be overridable in the environment.)