Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile-error "MSerial6 was not declared in this scope" #18149

Merged
merged 2 commits into from
May 31, 2020
Merged

fix compile-error "MSerial6 was not declared in this scope" #18149

merged 2 commits into from
May 31, 2020

Conversation

MoellerDi
Copy link
Contributor

Requirements

  • none

Description

This fix a compile-error after PR #18095 got merged

Benefits

no compile-error

Related Issues

no issues yet

@rudihorn
Copy link
Contributor

rudihorn commented May 30, 2020 •
edited
Loading

Actually just looking at https://github.com/stm32duino/Arduino_Core_STM32/blob/master/cores/arduino/HardwareSerial.h it seems there are a few more of these:

extern HardwareSerial Serial6;
extern HardwareSerial Serial7;
extern HardwareSerial Serial8;
extern HardwareSerial Serial9;
extern HardwareSerial Serial10;
extern HardwareSerial SerialLP1;

Could you please add these as well while you are at it?

@MoellerDi
Copy link
Contributor Author

@rudihorn sure ;-) I hope it's fine now

@rudihorn
Copy link
Contributor

Thanks! I think this can be merged now.

@thinkyhead thinkyhead added A: STM32 PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs. labels May 31, 2020
@thinkyhead thinkyhead merged commit d2d52e3 into MarlinFirmware:bugfix-2.0.x May 31, 2020
@MoellerDi MoellerDi deleted the patch-1 branch May 31, 2020 07:48
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
@MoellerDi
Declare MSerial6 (etc.) for STM32 (MarlinFirmware#18149)
fa23829
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
@MoellerDi @HairingX
Declare MSerial6 (etc.) for STM32 (MarlinFirmware#18149)
dbea95d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: STM32 PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoellerDi @rudihorn @thinkyhead