Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

rhapsodyv · 2020-06-24T19:25:53Z

Description

PR #18071 doesn't compile when defined TFT_LITTLE_VGL_UI.

This PR fixes all compilation erros. Note: I don't have the hardware to test.

Related Issues

#18071
#18401

rhapsodyv · 2020-06-24T19:26:31Z

@thisiskeithb Can you test it?

thinkyhead · 2020-06-24T19:53:57Z

Thanks for this. Unfortunately @makerbase-mks is too busy to do testing and patches at this time.

thisiskeithb · 2020-06-24T23:29:36Z

@thisiskeithb Can you test it?

It compiles, but I just get a blank screen after flashing. I'm still waiting to hear back from MKS/Makerbase as well since there's obviously something broken with their LVGL implementation.

rhapsodyv · 2020-06-25T03:20:55Z

@thisiskeithb Can you test it?

It compiles, but I just get a blank screen after flashing. I'm still waiting to hear back from MKS/Makerbase as well since there's obviously something broken with their LVGL implementation.

Did you put the mks_pic and mks_font in the SD root?

From here: https://github.com/makerbase-mks/MKS-Robin-Nano/tree/master/hardware

thisiskeithb · 2020-06-25T03:43:10Z

Did you put the mks_pic and mks_font in the SD root?

From here: https://github.com/makerbase-mks/MKS-Robin-Nano/tree/master/hardware

I tried both v1.x.x and v2.x.x releases, but the TFT is still blank on boot/the main view. If I touch around the TFT, it displays the same few (incorrect) icons in spots where icons should be, so something is still wonky.

Using MKS's precompiled firmware works and the TFT UI looks fine.

I've seen this on BigTreeTech TFTs when mixing and matching incorrect icons with different firmware releases, but I'm not sure where the correct icons should be downloaded from since the ones in MKS' repo do not work with the binary Marlin spits out.

Edit: I wonder if there's a way we can include those mks_pic and mks_font folders so users don't have to download them from another repo. An explainer should be added to Configuration.h with directions on where to download icons & fonts at the very least because I'm sure we'll hear about it in the issue queue once it works correctly.

rhapsodyv · 2020-06-25T06:56:57Z

The code is very very broken. I could get it working in my tft after much much debugging and tracing.
Things I discovered:

there’s a bug in the sd reading bin files that stop and don’t read anything
I couldn’t get the SPI_GRAPHIC_TFT to work (because my tft I think), but the fsmc mode that this code have is very broken. It’s even try use dma without initiating it...
the code has references for bin files that don’t match any file in the mks_pic folder (bmp_Motor_off.bin, bmp_Print.bin, etc)
a lot of files have case problem
the touch in the fsmc mode is broken too (spi mode I can’t test)
The flash spi have a weird bug that it overwrite it self. Maybe is my spi flash that don’t match the mks model, but the code is very weird. I didn’t find the cause yet.

rhapsodyv · 2020-06-25T06:59:00Z

rhapsodyv · 2020-06-25T07:04:38Z

The good thing, is that now I know very well how this code and lvgl works :-)

rhapsodyv · 2020-06-25T07:42:41Z

@thinkyhead do you think worth take the “working part” of this code and create a separated and independent full lvgl version for marlin?

rhapsodyv · 2020-06-25T20:53:01Z

Working with 2MB SPI Flash in my Tronxy X5SA, stock/original 480x320 TFT.

rhapsodyv · 2020-06-25T23:03:28Z

@thinkyhead
I can send a PR of this new UI. The goal will be: keep it simple, default and small so more users and displays could use.

The question now is, which path follow:

Create a copy of the code, to change it as we wish and need.

Pro -> It Keeps the MSK code untouched, so they continue to be the maintainer and don't mess up with their things.
Cons -> a few routines will be duplicated, at least until we change them

Change the original MKS code

Pro -> no code duplication
Cons -> It will change the MKS code in a way that they may not send more PRs to it because it may be incompatible with their current codebase.... I think the code will change a lot to keep it more generic and flexible (as I already did).

thinkyhead · 2020-06-25T23:29:57Z

they may not send more PRs to it

If someone wants to help them stay up to date, they could submit a PR to the MKS fork with the changes.

rhapsodyv · 2020-06-25T23:37:02Z

they may not send more PRs to it

If someone wants to help them stay up to date, they could submit a PR to the MKS fork with the changes.

I'm really confident the PR they sent is a way way outdated with their current "real" codebase.

But, we can try reach them... It'll be good for everyone.

thisiskeithb · 2020-06-25T23:38:15Z

But, we can try reach them... It'll be good for everyone.

I have direct contact with MKS, but they are on holiday right now for the Dragon Boat Festival, so it'll be a few days at the earliest before I hear back.

rhapsodyv · 2020-06-26T00:12:01Z

But, we can try reach them... It'll be good for everyone.

I have direct contact with MKS, but they are on holiday right now for the Dragon Boat Festival, so it'll be a few days at the earliest before I hear back.

Ok. Let's wait.

I think I finished almost everything, but gcode preview. I will test new in the printer now. And prepare a PR.

thisiskeithb · 2020-06-26T00:21:46Z

Thanks for debugging this! I'll be able to test this on a real Robin Nano/TFT35 combo later today or tomorrow if you want to send me a link to your branch.

makerbase-mks · 2020-06-26T01:46:41Z

Now the location of some files has changed, some header file paths have not been changed, I will modify and test it, and then submit to the marlin team for review.

thinkyhead · 2020-06-26T04:28:02Z

Thanks @makerbase-mks. I look forward to your patch!

* TMCStepper 0.7.0 followup (MarlinFirmware#18388) * Improve U8G+SPI delay override (MarlinFirmware#18386) Co-authored-by: Scott Lahteine <github@thinkyhead.com> * Better STM32 Tone timer int priority (MarlinFirmware#18385) * Fix 3-point middle point (MarlinFirmware#18383) * Fix LPC176x RGB NEOPIXEL startup (MarlinFirmware#18380) * Fix ExtUI automatic font scaling (MarlinFirmware#18377) * [cron] Bump distribution date (2020-06-23) * No 'probing failed' with retry (MarlinFirmware#18379) * Add SERIAL_FLOAT_PRECISION option (MarlinFirmware#18367) * Move tests up one level * Use libraries from the registry * Graphical LCD note * Update LPC176x platform version (MarlinFirmware#18392) * Add maintenance actions * [cron] Bump distribution date (2020-06-24) * General cleanup * Run close-stale once per day * Board-based ST7920 delays * TFT_LITTLE_VGL_UI followup (MarlinFirmware#18410) * Display PID Autotune status (MarlinFirmware#18408) * [cron] Bump distribution date (2020-06-25) * Use Preheat 1 as M303 default (MarlinFirmware#18407) * Fix issues with no hotend / bed / fan (MarlinFirmware#18395) * Fix material preset type * NO_LCD_REINIT for FSMC (or, no SD_DETECT_PIN) * Fix material preset editing * Clean up preheat edit items * [cron] Bump distribution date (2020-06-26) * Minor LCD cleanup, improvement * Fix typo in DWIN, preheat array * Update Italian language (MarlinFirmware#18414) * [samd51] Manifest assigned timers priority (MarlinFirmware#18402) * Update MKS Robin Nano auto-build env (MarlinFirmware#18417) * SAMD51 cleanup (MarlinFirmware#18419) * BTT SKR Pro runout pins (MarlinFirmware#18416) * Update Brazilian Portuguese language (MarlinFirmware#18411) * Fix Fan Speed menu items (MarlinFirmware#18400) * Patch some DGUS warnings * Allow larger ADC debounce Reference MarlinFirmware#17205 * [cron] Bump distribution date (2020-06-27) * [cron] Bump distribution date (2020-06-28) * Update language fonts * Tool Change Migration fixes and debugging (MarlinFirmware#18448) * ExtUI additions (MarlinFirmware#18447) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Add Romanian language (MarlinFirmware#18455) Co-authored-by: cristyanul <47246451+cristyanul@users.noreply.github.com> * Fix "probing failed" false positives (MarlinFirmware#18435) * Adjustable delta_diagonal_rod_trim (MarlinFirmware#18423) * Russian, Ukranian for wide LCD (MarlinFirmware#18433) * Tweak pins formatting * Suppress unused var warning * ClosedLoop as singleton * [cron] Bump distribution date (2020-06-29) * MKS Robin Nano flash-based EEPROM (MarlinFirmware#18466) * Use "reset reason" defines (MarlinFirmware#18462) * [cron] Bump distribution date (2020-06-30) * [cron] Bump distribution date (2020-07-01) * Fix missing parenthesis (MarlinFirmware#18473) * Fix FYSETC CHEETAH V1.2 SD re-insert (MarlinFirmware#18474) Include this board with other Cheetah stepper reset. * Hide menu item with no fan (MarlinFirmware#18470) * Permit independent X2,Y2,Z2,Z3,Z4 endstop inverting (MarlinFirmware#18481) * Add TFT_LVGL_UI support (MarlinFirmware#18438) * Per-Hotend Default PIDs (MarlinFirmware#18483) * Enforce sensor range for temperature target (MarlinFirmware#18465) * Mitigate stepper timeout * Add CHAMBER PWM code * Structured thermistor tables * Fix reversed sensor ranges * Prevent temps outside sensor range * [cron] Bump distribution date (2020-07-02) * Tweak stepper shutdown test * Extend thermistor 1047 to 500°C * [cron] Bump distribution date (2020-07-03) * Keep filament runout pin for Creality Melzi (MarlinFirmware#18504) * Add FYSETC 2.42 inch OLED support (MarlinFirmware#18485) * Option to set manual Babystepping distance in mm (MarlinFirmware#18503) Co-authored-by: Scott Lahteine <github@thinkyhead.com> * Clean up LCD Manual Move / UBL Mesh Edit (MarlinFirmware#18373) * FYSETC OLED followup (MarlinFirmware#18519) * Ensure Git applies Unix line-endings in tests (MarlinFirmware#18495) * Fix axis name in serial output (MarlinFirmware#18522) * Fix env:mks_robin_nano35 (MarlinFirmware#18516) * FIx Sanguino/1284p board_upload.maximum_size (MarlinFirmware#18502) * M150 I to set Neopixel by index (MarlinFirmware#18490) * [cron] Bump distribution date (2020-07-04) * PID Accelerated Edit (MarlinFirmware#18532) * [cron] Bump distribution date (2020-07-05) * Fix "'ubl' not declared" error (MarlinFirmware#18541) * Fix thermistors exist-for-reading tests (MarlinFirmware#18533) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix "Probing mesh point" message Closes MarlinFirmware#17770 Co-Authored-By: Jan-Gerard van der Toorn <jan-gerard@users.noreply.github.com> * Probing points followup (MarlinFirmware#18552) * Update actions on bugfix branch * Add CI for pushed commits (MarlinFirmware#18549) * Fix Neopixel set_color (MarlinFirmware#18544) * Fix stall sensitivity adjustment for FTDI screens (MarlinFirmware#18554) * Minor pins cleanup * Add comment to M412 * Reduce string duplication * STM32: No compile-time check for PWM_PIN (MarlinFirmware#18539) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Filament Runout Inverting => State (MarlinFirmware#18537) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Simplify home_z_safely, respect HOME_AFTER_DEACTIVATE * [cron] Bump distribution date (2020-07-06) * Filament state followup * Get SAMD51 CXX flags from script * Use Material Preset 1 for PID autotune (MarlinFirmware#18446) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix broken POWER_LOSS_RECOVERY prompt (MarlinFirmware#18557) Co-authored-by: Scott Lahteine <github@thinkyhead.com> * Add Lerdge S,X,K (MarlinFirmware#18302) * Fix TMC homing phase coils alignment (MarlinFirmware#18528) Co-authored-by: Fabio Santos <fabiosan@live.com> * Scale runout distance setting for editable range (MarlinFirmware#18567) * 0.7.1 <= TMCStepper <= 0.7.9 (MarlinFirmware#18564) * Reduce 'first loop' temperature residency time (MarlinFirmware#18421) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Update and fix POWER_MONITOR (MarlinFirmware#18561) * [cron] Bump distribution date (2020-07-07) * Temp Residency followup * Combine command macros * Whitespace cleanup * Fix typo in Configuration_adv.h (MarlinFirmware#18570) * [cron] Bump distribution date (2020-07-08) * SKR 1.4 alert for unsupported LCD * Tweak PLR debug * Fix warning with PIO * Update Chinese (zh_CN) language (MarlinFirmware#18580) * Show fixed V in Power Display with no V sensor (MarlinFirmware#18579) * Fix User Temp Sensor (1000), reversed Pt100 / Pt1000 (MarlinFirmware#18590) * Add `Cap:RUNOUT` Co-Authored-By: Julius ter Pelkwijk <mrseeker@users.noreply.github.com> * Fix some comments * [cron] Bump distribution date (2020-07-09) * Fix missing controller fan include * Consolidate probe clearance, add section debug (MarlinFirmware#18576) * Better section / function log * Add do_z_clearance motion function * Remove outdated comment (MarlinFirmware#18597) * Clean up some MMU comments * MarlinUI support for up to 5 Material Presets (MarlinFirmware#18488) - Add `I` preset parameter to `G26`, `M106`, `M140`, and `M190`. - Extend menu items to permit a string interpolation. - Keep material names in a list and interpolate in menu items. - Extend material presets to support up to 5 predefined materials. Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: Scott Lahteine <github@thinkyhead.com> Co-authored-by: MoellerDi <MoellerDi@users.noreply.github.com> Co-authored-by: ellensp <ellensp@hotmail.com> Co-authored-by: RudolphRiedel <31180093+RudolphRiedel@users.noreply.github.com> Co-authored-by: thinkyhead <thinkyhead@users.noreply.github.com> Co-authored-by: Kirill Vergun <647149+o-nix@users.noreply.github.com> Co-authored-by: Fabio Santos <fabiosan@live.com> Co-authored-by: Chris Pepper <p3p@p3psoft.co.uk> Co-authored-by: Victor <rhapsodyv@gmail.com> Co-authored-by: Pascal de Bruijn <pmjdebruijn@pcode.nl> Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com> Co-authored-by: Keith Bennett <13375512+thisiskeithb@users.noreply.github.com> Co-authored-by: Johnny Eshak <info@johnnytheone.com> Co-authored-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com> Co-authored-by: cristyanul <47246451+cristyanul@users.noreply.github.com> Co-authored-by: JP Flouret <jflouret@microsoft.com> Co-authored-by: Serhiy-K <52166448+Serhiy-K@users.noreply.github.com> Co-authored-by: George Fu <nailao_5918@163.com> Co-authored-by: Robby Candra <robbycandra.mail@gmail.com> Co-authored-by: cbteeple <cbteeple@g.harvard.edu> Co-authored-by: notabucketofspam <43456540+notabucketofspam@users.noreply.github.com> Co-authored-by: Jan-Gerard van der Toorn <jan-gerard@users.noreply.github.com> Co-authored-by: Oliver Jean Eifler <olli.eifler@gmail.com> Co-authored-by: ManuelMcLure <manuel@mclure.org> Co-authored-by: GhostlyCrowd <jeffjiggens@gmail.com> Co-authored-by: Luc Hoang Long <i.me.mine@luchoanglong.com> Co-authored-by: J.C. Nelson <32139633+xC0000005@users.noreply.github.com> Co-authored-by: shuttercat <67816426+shuttercat@users.noreply.github.com> Co-authored-by: espr14 <espr14@gmail.com> Co-authored-by: cccc <cuiwei_cv@163.com> Co-authored-by: Julius ter Pelkwijk <mrseeker@users.noreply.github.com>

Fixes PR MarlinFirmware#18071 TFT_LITTLE_VGL_UI broken compilation

d1ad4fe

Update draw_error_message.h

50f7943

thinkyhead added the C: LCD & Controllers label Jun 24, 2020

thinkyhead merged commit 2a650a2 into MarlinFirmware:bugfix-2.0.x Jun 24, 2020

thisiskeithb mentioned this pull request Jun 24, 2020

Fix MKS LVGL includes #18401

Closed

rhapsodyv mentioned this pull request Jun 27, 2020

TFT_LITTLE_VGL_UI for everyone #18438

Merged

jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020

TFT_LITTLE_VGL_UI followup (MarlinFirmware#18410)

cf238e9

rhapsodyv deleted the fix-tft-little-vgl-ui branch October 25, 2020 00:29

HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021

TFT_LITTLE_VGL_UI followup (MarlinFirmware#18410)

95f4d49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

rhapsodyv commented Jun 24, 2020

rhapsodyv commented Jun 24, 2020

thinkyhead commented Jun 24, 2020

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 25, 2020

thisiskeithb commented Jun 25, 2020 •

edited

Loading

rhapsodyv commented Jun 25, 2020 •

edited

Loading

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

thinkyhead commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

thisiskeithb commented Jun 25, 2020

rhapsodyv commented Jun 26, 2020

thisiskeithb commented Jun 26, 2020

makerbase-mks commented Jun 26, 2020

thinkyhead commented Jun 26, 2020

Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

Conversation

rhapsodyv commented Jun 24, 2020

Description

Related Issues

rhapsodyv commented Jun 24, 2020

thinkyhead commented Jun 24, 2020

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 25, 2020

thisiskeithb commented Jun 25, 2020 • edited Loading

rhapsodyv commented Jun 25, 2020 • edited Loading

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

thinkyhead commented Jun 25, 2020

rhapsodyv commented Jun 25, 2020

thisiskeithb commented Jun 25, 2020

rhapsodyv commented Jun 26, 2020

thisiskeithb commented Jun 26, 2020

makerbase-mks commented Jun 26, 2020

thinkyhead commented Jun 26, 2020

thisiskeithb commented Jun 25, 2020 •

edited

Loading

rhapsodyv commented Jun 25, 2020 •

edited

Loading