Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filament Out port for Creality V4 Board #18763

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Add Filament Out port for Creality V4 Board #18763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Marlin/src/pins/stm32f1/pins_CREALITY_V4.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@

#define Z_PROBE_PIN PB1 // BLTouch IN

//
// Filament Runout Sensor
//
#ifndef FIL_RUNOUT_PIN
#define FIL_RUNOUT_PIN PA4 // "Pulled-high"
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the Ender 3 V2 example configuration should have FIL_RUNOUT_STATE LOW (the default) to indicate that the filament is out? Or, will it depend on the type of sensor installed by the end-user?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if the pin is "pulled high" when tested, this probably means the pin is uninitialized and that is the default state. If the default for the STM32 is to pull certain pins high (instead of leaving them floating) then this would make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this will affect the SD card reader since it is also specified as the SD_CS pin.

Copy link
Member

@thinkyhead thinkyhead Jul 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ONBOARD_SD_CS_PIN is not a named pin that Marlin uses.
AFAIK the onboard SD card reader is not on a shared SPI bus.


//
// Steppers
//
Expand Down