Fixes #18816 remove upload_extra_scripts.py from common_DUE_archim #18826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Select a board that uses common_DUE_archim environment, try to compile and upload.
Description
On windows the upload will fail.
The script Marlin/src/HAL/DUE/upload_extra_script.py modifies the bossac command line on windows machines.
This breaks uploads on windows. Works without it.
Benefits
Without the script it now uploads
Related Issues
issue #18816
Just waiting for conformation from user. It works on my clean windows install.