Marlin TFT port to LPC + Bonus: Full Hardware SPI Support #19139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l that implements TFT IO is compatible
rhapsodyv
changed the title
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Aug 28, 2020
…K8800-2.0.x * tag '2.0.6.1' of https://github.com/MarlinFirmware/Marlin: (195 commits) Version 2.0.6.1 [cron] Bump distribution date (2020-08-28) Add set_all_homed Mark axes not-homed with HOME_AFTER_DEACTIVATE (MarlinFirmware#18907) set_axis_not_trusted => set_axis_never_homed Independent Neopixel option (MarlinFirmware#19115) Fix Creality V4 probe pin Fix small typø Allocate sufficient MSG_MOVE_Z_DIST buffer One MARLIN_DEV_MODE warning per rebuild (MarlinFirmware#19163) FYSETC S6 2.0 (MarlinFirmware#19140) [cron] Bump distribution date (2020-08-27) Fix SINGLENOZZLE fan speed bug (MarlinFirmware#19152) Fix NEOPIXEL_STARTUP_TEST last delay (MarlinFirmware#19156) TFT (plus Hardware SPI) for LPC (MarlinFirmware#19139) Prusa => Průša Direct Stepping update (MarlinFirmware#19135) Fixes to FTDI Touch UI (MarlinFirmware#19134) Add Einsy Rambo Filament Runout Pin (MarlinFirmware#19136) Fix SD pins for SKR Pro and GTR (MarlinFirmware#19047) ...
This was referenced Aug 29, 2020
Merged
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Sep 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ported the TFT IO to LPC. Tested in a SKR 1.4 and Emulated DOGM and New Color UI are working using HW SPI, and a MKS SPI TFT.
To work with TFT in LPC, I needed a way to use a multi bus SPI, because the TOUCH and TFT are both SPI, with different requirements.
So, I wrote the same SPIClass that already exists in others HALs to LPC, with full support for:
Important: I didn't touch the current SPI methods from LPC. Only the new code is using the new class. To not break anything.
All implemented options can be used at the same instance, just need to call begin/end to change and select the current SPI config.
Done:
TODO:
Benefits
Related Issues
#19017
#18974
This new SPIClass could help #19047 too,as it support changing the spi as needed.I just send a PR to @p3p , because the
framework-arduino-lpc176xneeds a 2 line fix to work with DMA 16 bit.p3p/pio-framework-arduino-lpc176x#43
I would like to ask @p3p and @sjasonsmith to review it this PR. It is the first working version, so I can surely improve it.