SD Init Fail message only when we can detect the SD Card Insertion #19236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther way will be showing SD Init Fail forever
|
still sd init fail |
|
I tested these changes on the following configs and no longer get "SD Init Fail" on boot:
Thank you! |
I just tested the fix on an SKR Mini E3 1.2 with |
|
@thisiskeithb @rhapsodyv Sorry!!! Glad we could all work through this Thank you!!! |
mikemerryguy
approved these changes
Sep 2, 2020
mikemerryguy
approved these changes
Sep 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only show sd init fail on card.mount if we can detect the card.
If we can't detect the sd card, the actual code shows "SD Init Fail" forever, because the card.mount is called in the marlin main loop always....
Benefits
Related Issues
#19064
#19226