Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration_adv.h: disable LASER_POWER_INLINE #19726

Closed
wants to merge 1 commit into from

Conversation

IamPete1
Copy link
Contributor

@IamPete1 IamPete1 commented Oct 13, 2020

LASER_POWER_INLINE causes many laser cuter GCode generators to be none functional in 'marlin' mode. LightBurn in my case. #18965 #18965 (comment)

LASER_POWER_INLINE causes many laser cuter GCode generates to be none functional in 'marlin' mode. LightBurn in my case. MarlinFirmware#18965 MarlinFirmware#18965 (comment)
@thinkyhead
Copy link
Member

Thanks for your contribution! Unfortunately we can't accept PRs directed at release branches. We make patches to the bugfix branches and only later do we push them out as releases. Please redo this PR starting with the bugfix-2.0.x branch and be careful to target bugfix-2.0.x when resubmitting the PR.

It may help to set your fork's default branch to bugfix-2.0.x.

See http://marlinfw.org/docs/development/getting_started_pull_requests.html for full instructions.

@IamPete1
Copy link
Contributor Author

@thinkyhead Thanks, I was being lazy and using the online editor and not reading the instructions. Hopefully I have got it right on the second attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants