LCD position in current units

[rdhoggattjr]

Requirements

• Filling out this template is required. Pull Requests without a clear description may be closed at the maintainers' discretion.

Description

Adds an option if 'INCH_MODE_SUPPORT' is enabled to show XYZ Coordinate's in inches on the status screen when G20 is active.

Benefits

INCH_MODE_SUPPORT lets you use inches but still display's the current position in mm. This changes that.

Configurations

Sorry, I've never contributed on Github before so I don't know if this is right but I'll put a basic Configuration.h with the display I
have turned on.
Configuration.txt

Related Issues

[rdhoggattjr]

I have a possibly dumb question, but if I rebase and squish all the commits will it update the PR? And if so will it mess up the PR in some way?

Sorry for the questions but I'm new to Git/Github and still trying to learn.

[sjasonsmith]

@rdhoggattjr if you rebase you have to force-push to your branch to update the PR. It causes the review to lose some continuity because you can't see the changes made between commits if you rebase. I believe comments made on the code also don't track properly across a rebase.

I believe that when thinkyhead merges PRs they are usually done a squash merge, which is going to condense this all down to one commit. You don't need to worry about there being a large number of commits since that will happen anyway.

[sjasonsmith]

It hurts me a little to see the expansion of "inch" capability, and I know this PR has been a little controversial in some of the forums for that reason. That said, if using things alongside existing inch-based CNC machinery I can appreciate the desire for some consistency. I myself have to frequently switch between mm and inches depending on whether I am using a 3D printer or a CNC mill.

[rdhoggattjr]

Yeah, I'm using Marlin with a CNC converted Mill that uses inches already.

[rdhoggattjr]

I'm thinking I may need to put in some check for the LCD being used as this only works with certain controllers?

How does testing normally work for changes when you don't have access to every setup? Or do I limit it to known compatible hardware at the moment and leave it for someone with said hardware to port it?

[thinkyhead]

Since the idea is to make inch support more complete across the UI, the UI should simply reflect the current units as set by M20 / M21 without need for a new option. The code can just use the LINEAR_UNIT macro in parser.h to display the correct value, converted from mm. And it can test whether inches mode is enabled with the addition of…

static inline bool using_inch_units() { return mm_to_linear_unit(1.0f) != 1.0f; }

…to decide whether to display mm for millimeters or in (or possibly ") for inches, where appropriate. Marlin is already set up so that the output of M503 and other codes that report positions and lengths will automatically output inches when in inches mode.

[rdhoggattjr]

@thinkyhead 5aff43e is what I think you were getting at? If so I'll test it on my test bed tonight.

Thank you for your input also.

[rdhoggattjr]

Sorry for all the questions, I just want to make sure I'm doing things right.

I also have code that changes the move axis menu to inch when G20 is active. My question is would it be better to start a new pull request for that or commiting it here since this seems to be changing from an option to working towards completing one?

[thinkyhead]

When it comes to PRs, you can tweak your command history in your working copy all you like then use git push -f to update the PR to your current state. But, if now this PR's "Files" changes all look correct then it can go forward from here.

[rdhoggattjr]

When it comes to PRs, you can tweak your command history in your working copy all you like then use git push -f to update the PR to your current state. But, if now this PR's "Files" changes all look correct then it can go forward from here.

@thinkyhead Everything seems to be looking good. Now I'm just going though the code to try and make it look cleaner, then it should be good for hopefully a final review from someone.

[rdhoggattjr]

@thinkyhead I wish I was more knowledgeable in coding. You make it look easy. If you don't mind me asking, what happens now?

[sjasonsmith]

@rdhoggattjr did you test with all the recent changes thinyhead added?

I believe his changes make it so that it will switch as you switch units through gcode. It would be great if you can test that ability to switch back and forth.

[rdhoggattjr]

@rdhoggattjr did you test with all the recent changes thinyhead added?

I believe his changes make it so that it will switch as you switch units through gcode. It would be great if you can test that ability to switch back and forth.

@sjasonsmith It works great on my test bed. I have a mega2560 with ramps and full discount graphics sitting next to my chair that I use to test as I'm coding.

The only thing that I seen was that M114 still reports mm all the time, but I wasn't going to mess with it because of Octoprint or others that might use it and could possibly cause issues.