Fix NO_SD_HOST_DRIVE when shared media is not supported #20176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke NO_SD_HOST_DRIVE work properly in all hals and only when sd host exist
rhapsodyv
added
Needs: Testing
thinkyhead
approved these changes
Nov 18, 2020
FhlostonParadise
pushed a commit
to FhlostonParadise/Marlin
that referenced
this pull request
Nov 21, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Kannix2005
pushed a commit
to Kannix2005/Marlin-1
that referenced
this pull request
Dec 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 7, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NO_SD_HOST_DRIVEhas partial support. Only LPC use it to enable/disable shared media. AndNO_SD_HOST_DRIVEwill disable SD_DETECT_PIN on boards that don't have shared media use onboard SD.This PR fix
NO_SD_HOST_DRIVEin all 32 bit HAL, and addHAS_SD_HOST_DRIVE, so each hal can say when it shared media is supported or not.HAS_SHARED_MEDIAbecame redundant withHAS_SD_HOST_DRIVE, so I replaced it.Benefits
Fix #20157
More MSC standard on all hals.
Related Issues
#20157