Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FTDI Bilinear build #20608

Conversation

sjasonsmith
Copy link
Contributor

@sjasonsmith sjasonsmith commented Dec 31, 2020

Description

A recent commit made the FTDI bed level screen build only when UBL is enabled. This seemed to be intentional. Presumably the implementation is only UBL-compatible.
#20393

A few additional changes were needed to complete the removal of the screen.

Benefits

Can build with FTDI enabled and BILINEAR instead of UBL.

Configurations

I tested with configs from this issue:
#20582

Related Issues

Fixes #20582

@sjasonsmith
Copy link
Contributor Author

sjasonsmith commented Dec 31, 2020

This fixes the compilation problem, but I can't actually test it.

@sjasonsmith sjasonsmith linked an issue Dec 31, 2020 that may be closed by this pull request
@sjasonsmith sjasonsmith added the Needs: Testing Testing is needed for this change label Jan 1, 2021
@sjasonsmith
Copy link
Contributor Author

I realized I tagged the wrong user earlier. We need @Lino77 to try this out.

@sjasonsmith
Copy link
Contributor Author

This is addressed differently in another open PR. I don't know which version is more correct.
#20657.

@sjasonsmith sjasonsmith closed this Jan 4, 2021
@sjasonsmith sjasonsmith deleted the PR/Bug20582_FTDI_BedLevel branch April 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Testing Testing is needed for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FTDI EVE fails to build with AUTO_BED_LEVELING_BILINEAR
1 participant