-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Status Area for DWIN Display #20983
Conversation
@ETE-Design What I have already written should be able to be adapted to tie into the marlin UI features, so as time goes on I will most likely slowly migrate the features to the marlin UI framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two comments - I have no other objections to this code. I have tested and it seems to do exactly what it states - which is a good addition to the DWIN ecosystem.
Marlin/src/lcd/dwin/e3v2/dwin.cpp
Outdated
if (current_position.z != z) { | ||
z = current_position.z; | ||
DWIN_Draw_FloatValue(true, true, 0, font8x16, Color_White, Color_Bg_Black, 3, 1, 205, 459, current_position.z * 10); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the downwards part of a G29 probe, I noticed that the Z value hit 726.4. I'm not exactly sure why this is the case. Someone might be able to enlighten us here.
89cbc23
to
e193883
Compare
@thinkyhead - I'm trying to apply this to the current bugfix to test the changes, but it seems things are a bit confused. I normally grab a patch of the PR by adding .patch to the end of the URL, which gives me: When I apply this patch, a ton of it fails.
Do you have any suggestions on how to fix this? I can't say I've had this problem before - but maybe from additional commits that were then shifted elsewhere? |
I generally just use git plus GitHub Desktop when I want to compare things. So first I might just look at the differences between this PR and the current bugfix code…
Anyway, all you really need to do is check out the PR directly, because it is already applied to the current If you have the branch checked out and all you want to do is see the differences in isolation, or squashed to a single commit, you could use…
|
@thinkyhead - Thanks I'm pretty sure I got this right. So from a UI perspective, the only thing I see that doesn't work atm is the ???.? and blink parts. Is that expected with the current status? |
Thank you for your PR I applied it successfully to my fork. |
The logic to blink the positions is similar to that used for other displays. If it's not working now then it can be adjusted. I need to flash and test some other things on the Ender-3 V2 so I will test these updates shortly. In the long run, of course, we want to get rid of the custom menu code in |
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
Description
An improved status area for the Ender 3 V2 DWIN LCD display.
This is a small portion of a complete rewrite I have done for the DWIN display, which is why it contains a couple new global variables which will come into use as I submit more aspects of the rewrite in future PRs.
Requirements
An Ender 3 V2 with its stock DWIN Display
Benefits
Significantly more information in the status area of the display. Including flow rate, fan speed, and the current x, y, and z axis coordinates.
Configurations
Ender 3 V2 Config.zip