Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SKR 1.4 UART3 Environment #21261

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

thisiskeithb
Copy link
Member

Description

PR #21254 introduced some new warnings & build errors for the SKR 1.4, so this corrects the platform line so the new LPC1768_btt_skr_v1_4 PIO environment compiles correctly.

H/T to @rhapsodyv for the fix.

Requirements

SKR 1.4 with new LPC1768_btt_skr_v1_4 PIO environment.

Benefits

No more "Can not remove temporary directory /github/Marlin/.pio/build. Please remove it manually to avoid build issues" or "Error: Invalid '/github/Marlin/platformio.ini' (project configuration file): 'No section: 'LPC1768''" warnings/errors.

Configurations

Any BOARD_BTT_SKR_V1_4 config.

Related Issues

#21259

@thisiskeithb
Copy link
Member Author

thisiskeithb commented Mar 5, 2021

What about the SKR 1.4 Turbo? It's identical in every way to the SKR 1.4, but has an LPC1769 instead of LPC1768 MCU.

Should we add an LPC1769_btt_skr_v1_4_turbo PIO environment?

@p3p
Copy link
Member

p3p commented Mar 5, 2021

Should we add an LPC1768_btt_skr_v1_4_turbo PIO environment?

Adding the extra envs is not the correct workaround for removing the board flags feature, all it does is complicate matters, I think using the platformio.ini features as mentioned in this comment #21254 (comment) would be cleaner.

@thisiskeithb
Copy link
Member Author

Adding the extra envs is not the correct workaround for removing the board flags feature

I was going to mimic what was already merged, but I'm happy to make the change any way you prefer.

@thisiskeithb
Copy link
Member Author

I think using the platformio.ini features as mentioned in this comment #21254 (comment) would be cleaner.

Looking at that again, it is!

The biggest advantage of that method is that it doesn’t invalidate all current documentation on which environment to use.

@thinkyhead thinkyhead merged commit 3eb8e26 into MarlinFirmware:bugfix-2.0.x Mar 6, 2021
@thisiskeithb thisiskeithb deleted the patch-1 branch March 6, 2021 08:13
vyacheslav-shubin pushed a commit to vyacheslav-shubin/Marlin that referenced this pull request Mar 10, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants