Add TEMP_SENSOR_BOARD

[slowbro]

Description

Add TEMP_SENSOR_BOARD for motherboards with integrated/onboard temperature sensors, and integrate it with USE_CONTROLLER_FAN.

Requirements

The only two boards I know of that have an on-board sensor are BOARD_DUE3DOM_MINI and BOARD_BTT_SKR_E3_TURBO, though this doesn't necessarily require an on-board sensor; one could just use a normal thermistor on an available ADC pin.

Benefits

Previously, users were assigning the onboard sensor to CHAMBER. This adds a dedicated sensor for the sensor, and allows using it for triggering CONTROLLER_FAN.

I added this as separate commits in case the second thing is unwanted; one could just drop that commit.

Configurations

#define TEMP_BOARD_PIN 11
#define TEMP_SENSOR_BOARD 1

#define USE_CONTROLLER_FAN
#if ENABLED(USE_CONTROLLER_FAN)
  #define CONTROLLER_FAN_PIN 12           // Set a custom pin for the controller fan
  //#define CONTROLLER_FAN_USE_Z_ONLY       // With this option only the Z axis is considered
  //#define CONTROLLER_FAN_IGNORE_Z         // Ignore Z stepper. Useful when stepper timeout is disabled.
  #define CONTROLLERFAN_SPEED_MIN         0 // (0-255) Minimum speed. (If set below this value the fan is turned off.)
  #define CONTROLLERFAN_SPEED_ACTIVE    255 // (0-255) Active speed, used when any motor is enabled
  #define CONTROLLERFAN_SPEED_IDLE        0 // (0-255) Idle speed, used when motors are disabled
  #define CONTROLLERFAN_IDLE_TIME        60 // (seconds) Extra time to keep the fan running after disabling motors

  #define CONTROLLER_FAN_USE_BOARD_TEMP   // Use TEMP_SENSOR_BOARD as a trigger for enabling the controller fan
  #if ENABLED(CONTROLLER_FAN_USE_BOARD_TEMP)
    #define CONTROLLER_FAN_TRIGGER_TEMP  30 // (°C) Enable the fan when the temperature reaches this temperature
  #endif
                                                                                                                                                                                                                                               
  //#define CONTROLLER_FAN_EDITABLE         // Enable M710 configurable settings
  #if ENABLED(CONTROLLER_FAN_EDITABLE)
    #define CONTROLLER_FAN_MENU             // Enable the Controller Fan submenu
  #endif
#endif

Related Issues

Resolves #20175

[slowbro]

Looking again at the FR, I am going to also add temperature protection for this sensor, i.e. MAXTEMP, as it seems users were utilizing that part of TEMP_SENSOR_CHAMBER.

[thinkyhead]

At a certain point it might make sense to stop defining specific types of temp sensors with heaters and/or fan control and/or PID control, and start thinking about just allowing users to define any number of general-purpose temperature sensors with associated temperature ranges and/or heaters and/or fan controls. Perhaps we are nearing that point.

[slowbro]

Yes, absolutely! That is something that has been on my mind for a bit, and I hoped to achieve something to that effect in a wholesale cleanup of the temperature module at some point in the near future. There is a lot of duplicated code that can easily be genericized and simplified. From the perspective of the user, more advanced boards simply label the temp inputs T0, T1, etc anywho - it would align things more with the real world. Plus, flexibility abound. I can switch gears to that, instead of adding another define, if you're up for a big change of that nature. It would rely on some stuff from #22196, but I could cherry pick from there as needed if that is still held up in review. Let me know what you think, and if you'd like to outline the goals of such a project.

[thisiskeithb]

The Einsy Rambo has a motherboard thermistor as well. I listed a few in my feature request, but I’ll see what else is out there: #20175

[slowbro]

The Einsy Rambo has a motherboard thermistor as well. I listed a few in my feature request, but I’ll see what else is out there: #20175

I wasn't able to find one on the Einsy. Looks like the additional ADC pin is used for the Z Probe.

https://github.com/ultimachine/Einsy-Rambo/blob/1.1a/board/Project%20Outputs/Schematic%20Prints_Einsy%20Rambo_1.1a.PDF

I may have missed it, however..

[thisiskeithb]

It'll be Therm 1, broken out as connector J3 (for some reason), but is the onboard thermistor:

some more old/bad info

Z Therm, or the probe thermistor, is in the probe connector J15:

Here's the pin:

Marlin/Marlin/src/pins/rambo/pins_EINSY_RAMBO.h

Line 118 in ee4c183

#define TEMP_1_PIN 1 // Analog Input

[slowbro]

Ah, yeah, that's odd that is has a second, with seemingly only the ability to control one extruder heater. I don't see an onboard PTC or anything in the schematics, though.. just seems like an extra temp header. I'll take your word for it, though, since I don't have one on-hand!

[thinkyhead]

Apparently, even AVR boards like the Uno have an onboard thermistor, generally considered not very accurate, so I suppose this common ADC device will need to be included as a standard feature. We can see about further generalizing the temperature sensor code as a follow-on to this PR.

[slowbro]

I'll resolve the conflicts, one minute.

[thisiskeithb]

I need to do some more investigating, but this locks up a BTT002 when enabled.

[slowbro]

@thisiskeithb I pored over the code a bit and realized I missed some things in thermistors.h - that may have been causing the hang on setup when it tries to find the proper mintemp/maxtemp. I also went through and fixed up some other things.

[slowbro]

rebased on current bugfix-2.0.x & force-pushed to re-start the tests - they had failed due to a github api timeout.

[slowbro]

LGTM, I like the HID_* changes, much more user-friendly!

[thisiskeithb]

@slowbro I'll ping you on Discord, but this still locks up a BTT002 and SKR E3 Turbo when enabled. Does it work on your boards?

[slowbro]

@thisiskeithb it was working for me on an SKR V2 when I tested. Let me take a look again with some other boards. I need to get my hands on a BTT002.

[slowbro]

OK, I found it. Couple of things; a) a copy-paste error in temeprature.cpp that I missed, and b) I neglected to add the required stuff to Conditionals_post. With those two fixes, it's no longer hanging on my SKR 1.4. #22343