Add option for M150 to control only the first LED strip

[sblaisot]

Description

When having two neopicel stripes and NEOPIXEL2_SEPARATE, before #22174 M150 without S parameter did control only first led strip. Since this PR has been merged, M150 without S parameter control both stripes simultaneously.

This could anoying when using led menu from a BTT TFT touchscreen for example which sends M150 commands without S parameter, depending on your hardware led setup.

This PR adds an option NEOPIXEL2_M150_CONTROL_FIRST for M150 to control only first strip instead of both when used without S parameter, bringing back former behaviour.

Requirements

Two neopixel strips with separate control pin for both.

Benefits

When having two neopixel led strips and sending M150 comands without S parameter you can choose if you want to control both strips or only the first one as if S0 was passed.

Configurations

Configuration.h

// Support for Adafruit NeoPixel LED driver
#define NEOPIXEL_LED
#if ENABLED(NEOPIXEL_LED)
  #define NEOPIXEL_TYPE             NEO_GRB  // NEO_GRBW / NEO_GRB - four/three channel driver type (defined in Adafruit_NeoPixel.h)
  //#define NEOPIXEL_PIN                  4  // LED driving pin
  #define NEOPIXEL2_TYPE            NEO_GRB
  //#define NEOPIXEL2_PIN                 3
  #define NEOPIXEL_PIXELS                15  // Number of LEDs in the strip. (Longest strip when NEOPIXEL2_SEPARATE is disabled.)
  #define NEOPIXEL_IS_SEQUENTIAL             // Sequential display for temperature change - LED by LED. Disable to change all LEDs at once.
  #define NEOPIXEL_BRIGHTNESS           127  // Initial brightness (0-255)
  //#define NEOPIXEL_STARTUP_TEST            // Cycle through colors at startup

  // Support for second Adafruit NeoPixel LED driver controlled with M150 S1 ...
  #define NEOPIXEL2_SEPARATE
  #if ENABLED(NEOPIXEL2_SEPARATE)
    #define NEOPIXEL2_PIXELS              3  // Number of LEDs in the second strip
    #define NEOPIXEL2_BRIGHTNESS        127  // Initial brightness (0-255)
    //#define NEOPIXEL2_STARTUP_TEST         // Cycle through colors at startup
    #define NEOPIXEL2_M150_CONTROL_FIRST     // By default M150 command without S parameter control both stripes. Enable to control first stripe only.
  #else
    //#define NEOPIXEL2_INSERIES      // Default behavior is NeoPixel 2 in parallel
  #endif

Configuration_adv.h

  /**
   * LED Control Menu
   * Add LED Control to the LCD menu
   */
  #define LED_CONTROL_MENU
  #if ENABLED(LED_CONTROL_MENU)
    #define LED_COLOR_PRESETS                 // Enable the Preset Color menu option
    #define NEO2_COLOR_PRESETS                // Enable a second NeoPixel Preset Color menu option
    #if ENABLED(LED_COLOR_PRESETS)
      #define LED_USER_PRESET_RED        255  // User defined RED value
      #define LED_USER_PRESET_GREEN      128  // User defined GREEN value
      #define LED_USER_PRESET_BLUE         0  // User defined BLUE value
      #define LED_USER_PRESET_WHITE      255  // User defined WHITE value
      #define LED_USER_PRESET_BRIGHTNESS 127  // User defined intensity
      //#define LED_USER_PRESET_STARTUP       // Have the printer display the user preset color on startup
    #endif
    #if ENABLED(NEO2_COLOR_PRESETS)
      #define NEO2_USER_PRESET_RED        255  // User defined RED value
      #define NEO2_USER_PRESET_GREEN      255  // User defined GREEN value
      #define NEO2_USER_PRESET_BLUE       255  // User defined BLUE value
      #define NEO2_USER_PRESET_WHITE      255  // User defined WHITE value
      #define NEO2_USER_PRESET_BRIGHTNESS 127  // User defined intensity
      #define NEO2_USER_PRESET_STARTUP         // Have the printer display the user preset color on startup for the second strip
    #endif
  #endif

Related Issues

This fixes #23063

[GeoSaffer]

Sounds like you should have the tft part updated.

M150 on its own controls both
M150 S0 controls 1st
M150 S1 controls 2nd

if you having difficulty controlling from tft, then it sounds like the tft code need to catchup with the changes

[sblaisot]

IMHO you can't blame a client for not using an option that is not even documented (S parameter is not documented. I want to make a PR for that also but waiting to see if this one merges before).

Will every setup with a single strip ignore S parameter? I mean, is it safe to use S0 parameter regarless of led type so I can add it to TFT?

[thinkyhead]

Note: The S parameter is available in M150 only when NEOPIXEL2_SEPARATE is enabled.

[thinkyhead]

FTR I'm not fond of adding options that transparently change the behavior of G-codes so that they don't behave consistently on all machines. Marlin is open source so that if this is the kind of thing you want for yourself you can make it happen by tweaking the code, but I don't see this option having broad universal appeal and it only serves to further dilute our work to establish stronger G-code standards.

[thinkyhead]

Maybe an option to affect a particular index by default would be better, instead of requiring the default one to be the first index. That will make it a little more flexible.