Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JYERSUI by LCH-77 #24451

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Update JYERSUI by LCH-77 #24451

merged 6 commits into from
Jul 6, 2022

Conversation

LCh-77
Copy link
Contributor

@LCh-77 LCh-77 commented Jul 4, 2022 •
edited by thinkyhead
Loading

This pull request modernizes JYERSUI while respecting the philosophy and code of Jacob.
Some modules were modded by me to be used in the UI, proper authorship is cited.
An enhanced version can be found here: https://github.com/LCh-77/Marlin/tree/bugfix-2.1.x_JYERSUI-Enhanced

  • PID plot
  • Gcode preview
  • Host Action Menu
  • Colorize UI
  • Junction Deviation
  • LED lights control
  • Shows boot screen when reset the printer
  • Firmware retracts menu
  • Off line, on click and live Z-Offset
  • Mesh leveling active indicator
  • Selectable 115200/250000 baud rate
  • Live brightness change
  • Support for M75 Filename to print
  • Probe settings menu
  • Endstop diagnostic
  • Screen lock

@thisiskeithb
Copy link
Member

It would help to have screenshots of some of these features, particularly “Colorize UI”.

@LCh-77
Copy link
Contributor Author

LCh-77 commented Jul 4, 2022

It would help to have screenshots of some of these features, particularly “Colorize UI”.

Sorry, the camera of my mobile is really bad, that in particular is not important, just moves to the dwin_defines.h some default UI colors for easy access and change.

LCh-77 and others added 4 commits July 4, 2022 12:07
@LCh-77
Update JYERSUI by LCH-77
ee8d17f 
- PID plot
- Gcode preview
- Host Action Menu
- Colorize UI
- Junction Deviation
- LED lights control
- Shows boot screen when reset the printer
- Firmware retracts menu
- Off line, on click and live Z-Offset
- Mesh leveling active indicator
- Selectable 115200/250000 baud rate
- Live brightness change
- Support for M75 Filename to print
- Probe settings menu
- Endstop diagnostic
- Screen lock
@LCh-77
No HAS_HOSTACTION_MENUS if HOST_ACTION_COMMANDS is disabled
fa382d1
@LCh-77
load baud settings only if BAUD_RATE_GCODE is enabled
41e06e1
@thinkyhead
misc. cleanup
6970b38
@thinkyhead thinkyhead merged commit a797390 into MarlinFirmware:bugfix-2.1.x Jul 6, 2022
@thisiskeithb
Copy link
Member

How are we supposed to know your alternate GitHub accounts were hacked?

@thinkyhead
Copy link
Member

What are you on about? Is there still confusion about Marlin GPLv3 licensing? If you distribute a binary, you must also give the recipient the code, and they are free to submit that code if they wish. It is not forbidden by any license. The code received strongly resembles code from @mriscoc and there is nothing particularly innovative in it, if I am TBH.

@thinkyhead
Copy link
Member

J'accuse!

In my humble opinion, you silly fools are the usurpers and are utterly out of your limited little minds. What do you think you're doing, trying to create private and relicensed versions of a GPLv3 project?

@thinkyhead
Copy link
Member

I am not translating your French. Your behavior is reprehensible, and you should be ashamed.

thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Jul 7, 2022
@thinkyhead
🔥 Remove JyersUI
f6bfd2f 
This reverts MarlinFirmware#24451
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Jul 7, 2022
@thinkyhead
🔥 Remove JyersUI
8aa4e3e 
This reverts MarlinFirmware#24451
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jul 7, 2022
@thinkyhead
🔥 Remove JyersUI
1acf813 
MarlinFirmware/Marlin#24451
thinkyhead pushed a commit that referenced this pull request Jul 7, 2022
@LCh-77 @thinkyhead
🚸 JyersUI updates (#24451)
509dfe9
@sjasonsmith
Copy link
Contributor

I read the latest comment from @CRCinAU , fellow Australian. I don't share his point of view. The facts quoted are not the reality. I followed this whole story. @CRCinAU isn't the last to ignite this situation. Besides, who is this LCh-77 that appeared as if by chance? Astonishing and suspicious. Is it Jyers?

Also an astonishing coincidence that your GitHub account was created 16 minutes ago.

@CRCinAU
Copy link
Contributor

CRCinAU commented Jul 7, 2022

I read the latest comment from @CRCinAU , fellow Australian. I don't share his point of view. The facts quoted are not the reality. I followed this whole story. @CRCinAU isn't the last to ignite this situation. Besides, who is this LCh-77 that appeared as if by chance? Astonishing and suspicious. Is it Jyers?

You may not agree. That's fine. Multiple contributors to Marlin have agreed on this decision. I offered to update my comment based feedback from contributors, it was generally agreed to be accurate and a quick summary of the facts. A such, the comment stands as a true and accurate account of events.

Lets move past this toxic time and leave it as sorted and look to the future instead of fostering infighting and spreading the toxic traits.

@LCh-77
Copy link
Contributor Author

LCh-77 commented Jul 7, 2022

What happened here? I didn't hack any account, this is my account, I think I didn't do anything wrong. Why is everyone fighting?
I only took the published code from the other UI and adapted it to be compatible with Jacob code because I don't want the JYERSUI to die. I didn't change the authorship. You can see my repository and the evolution of my code. Please! don't remove JYERSUI!

@LCh-77
Copy link
Contributor Author

LCh-77 commented Jul 7, 2022

@thisiskeithb @thinkyhead WARNING: My Pseudo Lch-77 is mine and it has been usurped! I am immediately reporting to Team Github! Unacceptable!!!!

That is false! that is my account!

@LCh-77
Copy link
Contributor Author

LCh-77 commented Jul 7, 2022

@LCh-77 Who are you . URSUPATEURS !!!!! Honte à toi de voler et de t'approprier mon travail. Honte à Marlin de ne pas faire la moindre vérification !!!

Please write in english, I don't know why you wrote that, is not your work, It's my work and others work that I cited.

@CRCinAU
Copy link
Contributor

CRCinAU commented Jul 7, 2022

Please write in english, I don't know why you wrote that, is not your work, It's my work and others work that I cited.

I haven't talked to you, but you may well just be an innocent person that has been caught in this toxic crossfire. You can see the stuff that the Marlin team has had to endure for many months now - which has ultimately brought us to this point.

Please don't take this personally - as it has no reflection on you or your contribution.

@LCh-77
Copy link
Contributor Author

LCh-77 commented Jul 7, 2022

How are we supposed to know your alternate GitHub accounts were hacked?

No, no, I don't hack any account.

@MarlinFirmware MarlinFirmware locked as too heated and limited conversation to collaborators Jul 7, 2022
@LCh-77 LCh-77 deleted the JYERSUI-Update branch July 21, 2022 19:22
@LCh-77 LCh-77 restored the JYERSUI-Update branch July 24, 2022 17:06
LCh-77 referenced this pull request Jul 24, 2022
@thinkyhead
✨ Reinstate JyersUI
007af47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
C: LCD & Controllers PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LCh-77 @thisiskeithb @thinkyhead @sjasonsmith @CRCinAU