-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CONTROLLER_FAN check to PID autotune #26652
Merged
thinkyhead
merged 21 commits into
MarlinFirmware:bugfix-2.1.x
from
ellensp:add-controller-fan-to-PID
Jan 10, 2024
+42
−16
Merged
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cb0065a
add USE_CONTROLLER_FAN to PID autotune
ellensp 8285aa7
remove code if not needed
ellensp 6b2ec79
remove cut and paste typo
ellensp eb73303
update the comment
ellensp 20e1470
generalize
thinkyhead 62fe985
more akin to idle()
thinkyhead 0a0683b
also manage_extruder_fans
thinkyhead 8505b91
ui.update for DWIN_CREALITY_LCD
thinkyhead 42a3ec9
tuning_idle as member
thinkyhead 5c0fa23
typo
thinkyhead a7b00a4
constexpr
thinkyhead 09baaec
use max_target
thinkyhead 6f7e3ab
'oldcolor'
thinkyhead 917e035
Merge branch 'bugfix-2.1.x' into pr/26652
thinkyhead 9679d52
clean up
thinkyhead 16a934a
struct for raw range
thinkyhead 2436858
not yet
thinkyhead 60a48ed
simplify temp_dir
thinkyhead 76db3f5
comma
thinkyhead 6494af0
tweak
thinkyhead 95787c3
Merge branch 'bugfix-2.1.x' into pr/26652
thinkyhead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, there is a general UI update… thought so. We can still poke through
manage_inactivity
to see if any other relevant items would be useful here, and we can still explore whether it would be okey-dokey to callidle()
during PID/MPC tuning without having any negative impact on the tuning process. I don't think that's ever been attempted.