Add auto restart on power loss if PLR is enabled. #26658
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My time is precious. Please make the effort to properly format the code as it will save me several minutes of extra work. |
vovodroid
force-pushed
the
plr-auto-restart-pr
branch
from
0e83856 to
f842739
Compare
|
Sorry, reformatted. I hope it's OK now. |
thinkyhead
reviewed
Jan 19, 2024
vovodroid
commented
Jan 19, 2024
Marlin/src/MarlinCore.cpp
Outdated
|
|
||
| for (uint16_t i = 0; i < PLR_REBOOT_TIMEOUT; i++) { | ||
| hal.watchdog_refresh(); | ||
| delay(1000); |
There was a problem hiding this comment.
I tried delay and safe_delay methods, but they seem freezing forever and system was restarted by watchdog after four seconds. The only working method I found was delayMicroseconds
vovodroid
force-pushed
the
plr-auto-restart-pr
branch
from
8eb7cbd to
f36ae2f
Compare
vovodroid
force-pushed
the
plr-auto-restart-pr
branch
from
f36ae2f to
ca7752a
Compare
|
I would combine this PR with PLR: heat bed while waiting for user confirmation. #26691 Thus if auto resume is disabled at least bed heating will start as soon as possible. |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
9c65146 to
4f65466
Compare
vovodroid
changed the title
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921 to
37fb26b
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
37d77d6 to
aa44542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements [FR] Power Loss Recovery with UPS: auto resume printing if power was immediately restored. #26604
This PR adds option for auto reboot if Auto power loss print resume with temperature limitation #26649 is enabled.
Usage scenario is if printer has UPS and power restored within seconds, while UPS still has a power, printer is stuck at "Restart" message, though it's desirable to continue immediately while the bed/chamber are still hot.