update pins pins_CREALITY_ENDER2P_V24S4, solves issue 26903 #26908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@ellensp & @thisiskeithb, how confident are you that this fix is universal? Is it possible there are more than one board being used with this pins file, and it needs to be split up? I don't know where the original broken values came from, which is why I'm concerned that fixing this for one user might be breaking it for someone else. |
|
I looked through your links and it seems like due-diligence was done and this is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pins_CREALITY_ENDER2P_V24S4.h has errors and causes KILL pin to be falsely triggered.
Updated to correct pin from information found online. https://gist.github.com/SteveGotthardt/33bdef27d1430f62b4fee5d723d0cde9
Has been tested and confirmed to work.
Requirements
Creality Ender 2 Pro motherboard CR-FDM-V2.4.S4.170
Benefits
Correct Pins
Related Issues
#26903