Add CORE support to st_get_position_mm (and elsewhere) #2995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2766 (aka #2782) by adding COREXY and COREXZ support to
st_get_position_mm
. Code that uses this function (including homing and probing routines) should now get the correct axis positions.The function
st_get_position_mm
has been renamedst_get_axis_position_mm
so it's clear that the values pertain to the cartesian axes, not necessarily to individual stepper positions.The first commit also fixes
endstops_trigsteps
so it uses the steps from both CORE steppers in the calculation. With this patched thecheckHitEndstops
function should display the correct positions.A second commit adds COREXY and COREXZ support to
M114
and changes the report output for cartesians also, so that they all report raw steps and not millimeters. This is a behavioral change to an extended, non-standard feature. (See theM114
documentation at reprap.org.)