Bugfix: G28 was lifting Z-axis multiple times #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Z_RAISE_BEFORE_HOMING was greater than zero
Closed
|
I thought that might be a potential side-effect for #3001. Now to see if this introduces a problem for some other combination… |
thinkyhead
added a commit
that referenced
this pull request
Mar 7, 2016
Bugfix: G28 was lifting Z-axis multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Z-axis was being lift multiple times if
Z_SAFE_HOMINGwas enabled andZ_RAISE_BEFORE_HOMINGwas greater than zero. I believe this bug must have been introduced by #3001.The visible side effect is XY homing will be really slow because each call to
HOMEAXIS()will be moving the axis plus the Z axis, in total Z will get raised4 * Z_RAISE_BEFORE_HOMINGmm.