Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always do a brief delay in lcd_quick_feedback #4140

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Always do a brief delay in lcd_quick_feedback #4140

merged 1 commit into from
Jun 25, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jun 24, 2016 •
edited
Loading

We forgot when creating the non-blocking beep classes that LCD buttons need the delay in lcd_quick_feedback or they tend to flake out.

Reference: #4127

@Blue-Marlin
Copy link
Contributor

We forgot

"Have been ignored" is the more exact term. (#3913 (comment))

@thinkyhead
Copy link
Member Author

thinkyhead commented Jun 25, 2016 •
edited
Loading

This 'blip' is part of the debouncer. So it cant be infinite short.

Not "ignored" — just lost in all the noise. Personally, I used to "know" this, but totally forgot.

@thinkyhead thinkyhead merged commit c8a9829 into MarlinFirmware:RCBugFix Jun 25, 2016
@thinkyhead thinkyhead deleted the rc_button_reliability branch June 25, 2016 03:05
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
Closed
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug: Confirmed ! PR: Bug Fix
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkyhead @Blue-Marlin @jbrazio