Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neaten up EEPROM read/write functions #4397

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Neaten up EEPROM read/write functions #4397

merged 2 commits into from
Jul 25, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jul 24, 2016 •
edited
Loading

  • Following the menu macro pattern, provide a "START_EEPROM" macro to declare and intialize the eeprom_index.
  • Simplify the read/write macros to use the designated local variable so there's no need to designate the offset in each use.
  • Shorten the read/write macro names, removing _VAR (as it's possible to write a constant, if one wished, and); it's clear enough without.

@thinkyhead thinkyhead force-pushed the rc_tweak_eeprom branch 2 times, most recently from fc058b9 to c3e9a0f Compare July 24, 2016 23:53
@thinkyhead thinkyhead merged commit 7c27f34 into MarlinFirmware:RCBugFix Jul 25, 2016
@thinkyhead thinkyhead deleted the rc_tweak_eeprom branch July 25, 2016 01:45
@jbrazio jbrazio added this to the 1.1.0 milestone Jul 25, 2016
@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: General Cleanup
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @jbrazio