Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M118 echo to serial #7168

Merged
merged 1 commit into from
Jun 28, 2017
Merged

M118 echo to serial #7168

merged 1 commit into from
Jun 28, 2017

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jun 28, 2017 •
edited
Loading

@thinkyhead thinkyhead force-pushed the bf_M217_echo_to_serial branch 3 times, most recently from 716d33b to 1a22e3b Compare June 28, 2017 05:51
@thinkyhead thinkyhead changed the title M217 echo to serial M118 echo to serial Jun 28, 2017
@thinkyhead thinkyhead force-pushed the bf_M217_echo_to_serial branch 2 times, most recently from 2500bff to bb3ce45 Compare June 28, 2017 05:54
@benlye @thinkyhead
Adding M118 command to send text to serial
98d362c 
Allows the user to send text to the serial console in order to
communicate with a host - sending debuging information or action
commands, for example.  Text must begin with '//' and this is added if
it is not already present at the beginning of the string.
@thinkyhead thinkyhead merged commit 797d6a9 into MarlinFirmware:bugfix-1.1.x Jun 28, 2017
@thinkyhead thinkyhead deleted the bf_M217_echo_to_serial branch June 28, 2017 06:12
@thinkyhead thinkyhead mentioned this pull request Jun 28, 2017
Closed
@benlye
Copy link
Contributor

benlye commented Jun 28, 2017

Cool. Let me check that adding echo: doesn't interfere with // action:command commands.

On the other hand, if the user wants the output to be echoed in Repetier Host, perhaps they could add echo: themselves, like M118 echo: Some text to output?

@benlye
Copy link
Contributor

benlye commented Jun 28, 2017

@thinkyhead, this doesn't do what I wanted because action commands aren't parsed if they start echo:

Can you remove SERIAL_ECHO_START(); and leave it up to the user to put in the echo: if they want the output to be echoed in Repetier?

@thinkyhead
Copy link
Member Author

No problem. Do you need the double slashes appended automatically?

@benlye benlye mentioned this pull request Jun 28, 2017
Closed
@benlye
Copy link
Contributor

benlye commented Jun 28, 2017 •
edited
Loading

No, happy to add those myself in my M118 commands.

@thinkyhead
Copy link
Member Author

How about this addition: M118 A will prepend double-slash, and M118 E will prepend echo:?

@thinkyhead thinkyhead mentioned this pull request Jun 28, 2017
Merged
@benlye
Copy link
Contributor

benlye commented Jun 28, 2017

How about this addition: M118 A will prepend double-slash, and M118 E will prepend echo:?

Not sure - seems like we might be over-thinking it now. Why not just let it send whatever string follows M118 and leave getting the syntax right for the use case up to the end-user?

@thinkyhead
Copy link
Member Author

Fair enough, though I might add the parameters too as a point of self-documentation for the G-code.

@benlye
Copy link
Contributor

benlye commented Jun 28, 2017

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @benlye