[1.1.x] Update pin definitions for PRINTRBOARD REV F. #7286

cscott · 2017-07-13T16:32:41Z

Allow use of Extrudrboard and REV F6. Disable JTAG to allow additional
pins to be used, and allow swapping channel A and B of the Extrudrboard
to accomodate REV F6.

thinkyhead · 2017-07-16T20:01:56Z

Marlin/pins_PRINTRBOARD_REVF.h

+// reassign different functions to EXP1.
+
+// Define NO_EXTRUDRBOARD_OUTPUT_SWAP if you have a REV F5 or lower and
+// want to use EXTRUDRBOARD A for E1 and EXTRUDRBOARD B for E2.


Please provide the defines, ready to be used:

// Define NO_EXTRUDRBOARD if you don't have an EXTRUDRBOARD and wish to // reassign different functions to EXP1. //#define NO_EXTRUDRBOARD // Define NO_EXTRUDRBOARD_OUTPUT_SWAP if you have a REV F5 or lower and // want to use EXTRUDRBOARD A for E1 and EXTRUDRBOARD B for E2. //#define NO_EXTRUDRBOARD_OUTPUT_SWAP

Wouldn't those #defines belong in your Configuration.h? I tried to avoid any need for an individual builder to edit pins_PRINTERBOARD_REVF.h.

I suggest keeping them in the pins file, since they pertain to no other board.

thinkyhead · 2017-07-16T20:02:04Z

Marlin/pins_PRINTRBOARD_REVF.h

 #define HEATER_BED_PIN     14   // C4 PWM3C

 #define FAN_PIN            16   // C6 PWM3A
+#define PRINTRBOARD_F6_HEATER_FAN_PIN 44 // pin F6 on REV F6, see above.
+
+#ifndef NO_EXTRUDRBOARD


For compatibility with Makefile and other build methods, these should be:

#if DISABLED(NO_EXTRUDRBOARD) #if DISABLED(NO_EXTRUDRBOARD_OUTPUT_SWAP)

You may want to double check these pin assignments.
Has anyone tested these pin assignments on a Printrboard Rev F with an Extrudrboard connected to Exp1? I have this configuration set up and the my pin assignments do not match the above configuration.

I am currently running this on my REV F5 with a stock extrudrboard and I've
checked this against the schematic for the REV F4 and REV F6 (available at
https://github.com/Printrbot/printrboard ). I'm guessing you're patching Printrbot's fork, which still uses the old fastio pin numbering and that's why these don't match your configuration. This is correct arduino numbering.

I just checked and the pins I was using were fastio.

thinkyhead · 2017-07-16T20:08:03Z

Marlin/pins_PRINTRBOARD_REVF.h

@@ -24,14 +24,17 @@
 *  Rev B  2 JUN 2017
 *
 *  Converted to Arduino pin numbering
+ *  at90usb1286 to arduino pin mapping is here:
+ *     https://labitat.dk/wiki/Panelolu_and_Printrboard_the_easy_way


Marlin no longer uses the so-called "Marlin mapping" or "fastio mapping" which numbers A0-A7 as 0-7, B0-B7 as 8-15, etc. We have killed that mapping. Thus the numbers marked in green on the linked page do not apply.

Marlin has switched to a unified Arduino-style pin mapping under fastio.h, including for all AT90USB processors. All Marlin code (with few exceptions) uses FastIO macros —such as READ, WRITE, etc.— allowing us to follow this mapping consistently.

Nor do we use the mapping provided by the Teensyduino headers. It's Arduino-style mapping all the way, in which the pin's "DIO number" is used as the pin number (except, 46 is pin E2 and 47 is pin E3.)

With that in mind, please make any necessary changes.

Yes, the linked page contains some additional pin numbers. But it also contains the arduino pin numbers, and that's what this comment explicitly references. I don't know why you are continuing to object to "fastio" when that doesn't appear anywhere in the patch.

The problem is there is some misinformation at that link, which is outdated and has shown to cause mounds of issues in the past. If history hadn't proven this over and over again (that link you found just one example of dozens online, and in this tracker), it wouldn't be such a stickling point.

If I have some time I may update the ASCII version of a similar chart that PrintrbotCo has at the top of their fork's pins.h file and incorporate it (or you can here !), but for now it is surely best to omit links that cite the old pins numbering in any form.

Correct. My comment is mainly due to the link being outdated and containing information that no longer pertains to Marlin. We have a website now, so if someone just throws together an update in Markdown format (e.g., a comment on Github will do), we may want to document this at marlinfw.org.

thinkyhead · 2017-07-16T20:45:26Z

@cscott Some comments for your consideration……

fiveangle · 2017-07-17T19:59:12Z

Sorry I haven't had time to try your build on my RevF - will try to soon !

fiveangle · 2017-07-17T23:00:41Z

Works over here @cscott !

fiveangle · 2017-07-18T00:51:51Z

Marlin/pins_PRINTRBOARD_REVF.h

+#ifndef USBCON
+  #error "USBCON should be defined by the platform for this board."
+#endif
+


I asked about this previously only because of issues around this historically with various instabilities surrounding USBCON (see #6550, #6737, #4171, #2433, etc)

So it sounds like it compiled correctly without this because the Teensyduino extension must define USBCON when the correct board is selected in the AIDE ? If so, defining again (in case user is not using Teensyduino) certainly sounds correct. If not, it begs the question how this is currently working without it.

Thanks,

-=dave

Concerns over the existence of USBCON were resolved with #6737 (comment) and #6889.

I just tested compilation of the other boards (with SD and ABL enabled but no LCD): TEENSYLU, TEENSY2, SAV_MKI, PRINTRBOARD, BRAINWAVE_PRO, 5DPRINT, (and of course PRINTRBOARD_REVF) with USBCON define removed from respective pins_[board].h and all compiled w/o issue.

It seems removal of USBCON define from all pins_[board].h would be appropriate, allowing serial.h to pull it in as appropriate from Arduino.h ?

And just tested BRAINWAVE (AT90USB647) with @Bob-the-Kuhn 's Marlin extension and it too compiled as expected w/o USBCON defined in the board pins file (of course the resulting sketch wouldn't fit, but i'm sure it could be made to).

Submitted #7347 for this to save you a few seconds in case this way you want to go Scott. If this isn't correct, just reject.

Did you find that the compilation size was identical with the USBCON defines removed?

Didn't check before, but just tested PRINTRBOARD with SD, Viki2, 3-PT (essentially stock config) and it came out identical.

...and just checked BRAINWAVE (only 647 board and uses Bob's custom extension) and also identical 👍

So the consensus is to remove the #ifndef check and #error here then?

Yeah. USBCON defines for all other AT90USB boards have already been removed.

cscott · 2017-07-28T19:25:51Z

Sorry, haven't had time to amend and retest the patch yet. Will do soon.

thinkyhead · 2017-08-05T08:39:56Z

As you find the time. I had to put off the 1.1.5 release for some additional patches, so if this is ready in the next day or two it may get into that release just under the wire.

thinkyhead · 2017-09-27T16:54:08Z

If this PR is in good shape, then we should get it merged, and also apply these changes to bugfix-2.0.x. Anything left to tweak before merging?

fiveangle · 2017-09-27T23:02:58Z

@thinkyhead - i have a bunch of changes to make to pb pins (and teensy group pins) to fix a grip of compile warnings that make Sublime Text 3/DevIoT PIO compiles take about 5x longer due to overhead of catting the never-ending stream of warnings to screen, but forgot about this PR.

I can incorporate this PR into mine, or you can merge this now, and then I'll rebase mine over the top. Whichever you prefer.

Let me know.

-=dave

thinkyhead · 2017-10-27T07:17:27Z

We're now into the weeds with 2.0.x, so I'll need to port this over to 2.0.x at the same time this gets merged. Will take care of that tomorrow….

fiveangle · 2017-11-13T05:34:25Z

Just sent up all my pending RevF changes, so I'll look at putting together PRs for this one sometime in the next month or so, since it appears somewhat abandoned.

thinkyhead · 2017-11-13T09:10:08Z

Anytime is good, Dave. Assuming no major issues, I hope to put out version 1.1.7 some time in the next 24 hours. If you're too busy to do this one, I'll try to squeak it in for the release.

thinkyhead · 2017-11-13T20:45:50Z

Marlin/pins_PRINTRBOARD_REVF.h

+  #define TEMP_2_PIN         TEMP_A_PIN
+  #define HEATER_2_PIN       HEATER_A_PIN
+
+#endif // NO_EXTRUDRBOARD_OUTPUT_SWAP


I get the general reasoning for doing it with intermediate named pins, such as for easier re-assignment, but really this is not needed. The pins file, once set, doesn't change, and if users need to edit the pins file for reassignment I'm sure they can figure out which of these blocks applies.

thinkyhead · 2017-11-13T21:14:16Z

I've got this one. Rebased, squashed, cleaned up, force-pushed.

cscott force-pushed the printrboard-rev-f branch from be13028 to 703531f Compare July 14, 2017 04:10

thinkyhead reviewed Jul 16, 2017

View reviewed changes

thinkyhead added the C: Boards/Pins label Jul 16, 2017

fiveangle reviewed Jul 18, 2017

View reviewed changes

thinkyhead changed the title ~~Update pin definitions for PRINTRBOARD REV F.~~ [1.1.x] Update pin definitions for PRINTRBOARD REV F. Oct 27, 2017

thinkyhead force-pushed the bugfix-1.1.x branch from bb58d68 to 524f4ee Compare November 3, 2017 08:57

thinkyhead reviewed Nov 13, 2017

View reviewed changes

thinkyhead force-pushed the printrboard-rev-f branch from 703531f to f7e8497 Compare November 13, 2017 21:13

thinkyhead mentioned this pull request Nov 13, 2017

[2.0] Support for Extrudrboard in Printrboard Rev.F #8408

Merged

thinkyhead added the PR: Improvement label Nov 13, 2017

thinkyhead added 2 commits November 13, 2017 15:47

Extrudrboard support for Printrboard Rev.F

90c7d28

Drop unused LARGE_FLASH option

d65c99f

thinkyhead force-pushed the printrboard-rev-f branch from 7e5ecf5 to d65c99f Compare November 13, 2017 21:47

thinkyhead merged commit 4e3b566 into MarlinFirmware:bugfix-1.1.x Nov 13, 2017

fiveangle mentioned this pull request Jan 2, 2018

PRINTRBOARD_F6_HEATER_FAN_PIN in pins_PRINTRBOARD_REVF.h is not defined #8976

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.1.x] Update pin definitions for PRINTRBOARD REV F. #7286

[1.1.x] Update pin definitions for PRINTRBOARD REV F. #7286

cscott commented Jul 13, 2017

thinkyhead Jul 16, 2017

cscott Jul 28, 2017

thinkyhead Aug 5, 2017

thinkyhead Jul 16, 2017 •

edited

Loading

cscott Jul 28, 2017

monstermark3d Jul 31, 2017 •

edited

Loading

cscott Aug 1, 2017

monstermark3d Aug 1, 2017

thinkyhead Jul 16, 2017 •

edited

Loading

cscott Jul 28, 2017

fiveangle Jul 28, 2017 •

edited

Loading

thinkyhead Aug 5, 2017 •

edited

Loading

thinkyhead commented Jul 16, 2017

fiveangle commented Jul 17, 2017

fiveangle commented Jul 17, 2017

fiveangle Jul 18, 2017 •

edited by thinkyhead

Loading

thinkyhead Jul 22, 2017 •

edited

Loading

fiveangle Jul 23, 2017 •

edited

Loading

fiveangle Jul 23, 2017

thinkyhead Jul 27, 2017

fiveangle Jul 27, 2017 •

edited

Loading

fiveangle Jul 27, 2017

cscott Jul 28, 2017

fiveangle Jul 28, 2017

cscott commented Jul 28, 2017

thinkyhead commented Aug 5, 2017

thinkyhead commented Sep 27, 2017

fiveangle commented Sep 27, 2017

thinkyhead commented Oct 27, 2017

fiveangle commented Nov 13, 2017

thinkyhead commented Nov 13, 2017

thinkyhead Nov 13, 2017

thinkyhead commented Nov 13, 2017

[1.1.x] Update pin definitions for PRINTRBOARD REV F. #7286

[1.1.x] Update pin definitions for PRINTRBOARD REV F. #7286

Conversation

cscott commented Jul 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkyhead Jul 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monstermark3d Jul 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkyhead Jul 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiveangle Jul 28, 2017 • edited Loading

Choose a reason for hiding this comment

thinkyhead Aug 5, 2017 • edited Loading

Choose a reason for hiding this comment

thinkyhead commented Jul 16, 2017

fiveangle commented Jul 17, 2017

fiveangle commented Jul 17, 2017

fiveangle Jul 18, 2017 • edited by thinkyhead Loading

Choose a reason for hiding this comment

thinkyhead Jul 22, 2017 • edited Loading

Choose a reason for hiding this comment

fiveangle Jul 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiveangle Jul 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cscott commented Jul 28, 2017

thinkyhead commented Aug 5, 2017

thinkyhead commented Sep 27, 2017

fiveangle commented Sep 27, 2017

thinkyhead commented Oct 27, 2017

fiveangle commented Nov 13, 2017

thinkyhead commented Nov 13, 2017

Choose a reason for hiding this comment

thinkyhead commented Nov 13, 2017

thinkyhead Jul 16, 2017 •

edited

Loading

monstermark3d Jul 31, 2017 •

edited

Loading

thinkyhead Jul 16, 2017 •

edited

Loading

fiveangle Jul 28, 2017 •

edited

Loading

thinkyhead Aug 5, 2017 •

edited

Loading

fiveangle Jul 18, 2017 •

edited by thinkyhead

Loading

thinkyhead Jul 22, 2017 •

edited

Loading

fiveangle Jul 23, 2017 •

edited

Loading

fiveangle Jul 27, 2017 •

edited

Loading