Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Group G-codes to fix command-line overflow #7719

Merged

Conversation

thinkyhead
Copy link
Member

Addressing #7707

Combine related G-codes together into single compilation units. This should reduce the command-line significantly in cases where paths are really long. In future, Arduino and/or gcc may get patched so they don't need to repeat paths. For example, by pre-defining shorthand for paths…

arduino-compile -DP1=/tmp/path/to/something -L %P1/somefile.o -L %P1/otherfile.o

This PR should also fix compile issues with case light. A similar patch will be needed for 1.1.x.

@thinkyhead thinkyhead added C: Build / Toolchain T: HAL & APIs Topic related to the HAL and internal APIs. labels Sep 23, 2017
@thinkyhead thinkyhead merged commit 6da97eb into MarlinFirmware:bugfix-2.0.x Sep 24, 2017
@thinkyhead thinkyhead deleted the bugfix_refactor_work branch September 24, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Build / Toolchain T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant