-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web: Created by view for dataset versions #1929
Conversation
…hlighting. Signed-off-by: Peter Hicks <peter@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #1929 +/- ##
============================================
- Coverage 78.23% 77.90% -0.34%
+ Complexity 955 937 -18
============================================
Files 194 193 -1
Lines 5293 5218 -75
Branches 420 418 -2
============================================
- Hits 4141 4065 -76
Misses 706 706
- Partials 446 447 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@phixMe, love to see the progress on this! I'm wondering, can we simplify the change by just linking the run that created the dataset? That is, in the version history tab, can we just have the In the latest schema tab, I would also just display the |
@phixMe: To not block the merge, let's address any feedback as follow up work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🛳️
Signed-off-by: Peter Hicks peter@datakin.com
Problem
Some Marquez users were eager to see the run that created a dataset version.
Solution
We've added the
Created by Run
section on the dataset page as well as the dataset version list view. Also updated is syntax highlighting support forsql
contexts and the empty states for context that is missing for us.Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)