Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marquez.podAnnotations #1945

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Apr 11, 2022

Problem

The helm chart does not support setting Marquez pod specific annotations.

Solution

Add marquez.podAnnotations to enable users to set Marquez pod specific annotations.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc added this to the 0.22.0 milestone Apr 11, 2022
Signed-off-by: wslulciuc <willy@datakin.com>
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1945 (7fff558) into main (ef063d7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1945   +/-   ##
=========================================
  Coverage     78.09%   78.09%           
  Complexity      944      944           
=========================================
  Files           193      193           
  Lines          5249     5249           
  Branches        418      418           
=========================================
  Hits           4099     4099           
  Misses          705      705           
  Partials        445      445           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wslulciuc wslulciuc merged commit 3f0d7a0 into main Apr 11, 2022
@wslulciuc wslulciuc deleted the feature/helm-mqz-api-annotation-support branch April 11, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants