-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration script and DAO updates for job renaming and symlinking #1947
Conversation
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1947 +/- ##
=========================================
Coverage 78.09% 78.09%
- Complexity 944 945 +1
=========================================
Files 193 193
Lines 5249 5251 +2
Branches 418 418
=========================================
+ Hits 4099 4101 +2
Misses 705 705
Partials 445 445
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@@ -78,6 +79,9 @@ private Columns() {} | |||
/* STREAM VERSION ROW COLUMNS */ | |||
public static final String SCHEMA_LOCATION = "schema_location"; | |||
|
|||
/* JOB ROW COLUMNS */ | |||
public static final String SYMLINK_TARGET_UUID = "symlink_target_uuid"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, I can imagine the renaming of datasets also requiring a symlink target column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to rename jobs using symlinks has been on the roadmap for a while! Great work, @collado-mike! Also, thanks for being so thorough with testing 💯 🥇
Problem
Part one of #1946
Implements the migration script and changes to
JobDao
andRunDao
to support symlinked jobs.Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)