Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix V45 migration to include initial population of jobs_fqn table #2051

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

collado-mike
Copy link
Collaborator

Problem

The V45 migration as is will cause no jobs or runs to be visible until the jobs_fqn table is populated. This adds a quick step to the migration to do the initial population, relying on the trigger function to handle new jobs as they are written.

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Michael Collado <collado.mike@gmail.com>
@collado-mike collado-mike requested a review from wslulciuc July 28, 2022 19:09
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #2051 (3a316c6) into main (2c21ab0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2051   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity     1011     1011           
=========================================
  Files           200      200           
  Lines          5573     5573           
  Branches        422      422           
=========================================
  Hits           4391     4391           
  Misses          730      730           
  Partials        452      452           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit 7151b5b into main Jul 28, 2022
@wslulciuc wslulciuc deleted the fix/V45_migration_populate_jobs_fqn branch July 28, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants