-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/symlinked jobs in queries #2053
Conversation
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
=========================================
Coverage 78.79% 78.79%
Complexity 1011 1011
=========================================
Files 200 200
Lines 5573 5573
Branches 422 422
=========================================
Hits 4391 4391
Misses 730 730
Partials 452 452 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on testing, otherwise LGTM 👍
Signed-off-by: Michael Collado <collado.mike@gmail.com>
0085f3e
to
48130fe
Compare
Build is repeatedly failing due to adoptium/adoptium-support#554 . I've gone ahead and merged the PR and we can watch the related issue |
Problem
A few fixes for the lineage query and the search queries related to symlinked jobs. These changes ensure that old and new jobs are found (users can search for aliases) and that new jobs continue to participate in the lineage of old jobs before they have new runs (previously, a job would have no lineage until that job was actually run).
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)