Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/symlinked jobs in queries #2053

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Conversation

collado-mike
Copy link
Collaborator

Problem

A few fixes for the lineage query and the search queries related to symlinked jobs. These changes ensure that old and new jobs are found (users can search for aliases) and that new jobs continue to participate in the lineage of old jobs before they have new runs (previously, a job would have no lineage until that job was actually run).

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
@collado-mike collado-mike requested a review from wslulciuc July 30, 2022 00:54
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #2053 (010c97b) into main (7151b5b) will not change coverage.
The diff coverage is n/a.

❗ Current head 010c97b differs from pull request most recent head 48130fe. Consider uploading reports for the commit 48130fe to get more accurate results

@@            Coverage Diff            @@
##               main    #2053   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity     1011     1011           
=========================================
  Files           200      200           
  Lines          5573     5573           
  Branches        422      422           
=========================================
  Hits           4391     4391           
  Misses          730      730           
  Partials        452      452           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on testing, otherwise LGTM 👍

Signed-off-by: Michael Collado <collado.mike@gmail.com>
@collado-mike collado-mike force-pushed the fix/symlinked_jobs_in_queries branch from 0085f3e to 48130fe Compare August 1, 2022 19:26
@collado-mike collado-mike enabled auto-merge (squash) August 1, 2022 19:41
@collado-mike collado-mike disabled auto-merge August 1, 2022 20:36
@collado-mike collado-mike merged commit 90feb2e into main Aug 1, 2022
@collado-mike collado-mike deleted the fix/symlinked_jobs_in_queries branch August 1, 2022 20:36
@collado-mike
Copy link
Collaborator Author

Build is repeatedly failing due to adoptium/adoptium-support#554 . I've gone ahead and merged the PR and we can watch the related issue

@wslulciuc wslulciuc mentioned this pull request Aug 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants