Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlywayFactory to support custom schema #2055

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

collado-mike
Copy link
Collaborator

Problem

There's currently no way to customize the marquez database to use a custom schema. This updates the FlywayFactory to support an argument to customize the schema programatically. This doesn't aim to support custom schemas from configuration.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@collado-mike collado-mike requested a review from wslulciuc August 2, 2022 16:55
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2055 (1379bb3) into main (005b418) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1379bb3 differs from pull request most recent head 1e92e53. Consider uploading reports for the commit 1e92e53 to get more accurate results

@@            Coverage Diff            @@
##               main    #2055   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity     1011     1011           
=========================================
  Files           200      200           
  Lines          5573     5574    +1     
  Branches        422      422           
=========================================
+ Hits           4391     4392    +1     
  Misses          730      730           
  Partials        452      452           
Impacted Files Coverage Δ
api/src/main/java/marquez/db/FlywayFactory.java 97.05% <100.00%> (+0.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@collado-mike collado-mike force-pushed the feature/flyway_custom_schemas branch from 1bbb3db to 7ee8990 Compare August 8, 2022 19:02
Signed-off-by: Michael Collado <collado.mike@gmail.com>
@collado-mike collado-mike force-pushed the feature/flyway_custom_schemas branch from 7ee8990 to 1379bb3 Compare August 8, 2022 19:11
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) August 9, 2022 22:17
@wslulciuc wslulciuc merged commit 1330831 into main Aug 9, 2022
@wslulciuc wslulciuc deleted the feature/flyway_custom_schemas branch August 9, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants