Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum string types in openapi spec #2086

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

studiosciences
Copy link
Contributor

@studiosciences studiosciences commented Aug 24, 2022

Problem

type: enum is not valid in OpenAPI specs.
https://spec.openapis.org/oas/v3.1.0#data-types

Closes: #2085

Solution

It's suppose to be a type: string with of enum values.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@studiosciences studiosciences force-pushed the fix/openapi-enum branch 2 times, most recently from c3b841d to a445a79 Compare August 24, 2022 21:37
Signed-off-by: Marc Robichaud <marc@studiosciences.ca>
@studiosciences studiosciences marked this pull request as ready for review August 24, 2022 21:41
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @studiosciences! 💯

@wslulciuc wslulciuc enabled auto-merge (squash) August 24, 2022 21:42
@wslulciuc wslulciuc merged commit e25a6c3 into MarquezProject:main Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #2086 (bd6b89a) into main (7da23da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2086   +/-   ##
=========================================
  Coverage     77.04%   77.04%           
  Complexity     1013     1013           
=========================================
  Files           201      201           
  Lines          4643     4643           
  Branches        389      389           
=========================================
  Hits           3577     3577           
  Misses          628      628           
  Partials        438      438           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect types for enums in OpenAPI spec
2 participants