Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect postgressql version #2089

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

jabbera
Copy link
Contributor

@jabbera jabbera commented Aug 25, 2022

Problem

No such tag exists for postgressql. This appears to be an accidental change.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #2089 (1c3a8e1) into main (e25a6c3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2089   +/-   ##
=========================================
  Coverage     77.04%   77.04%           
  Complexity     1013     1013           
=========================================
  Files           201      201           
  Lines          4643     4643           
  Branches        389      389           
=========================================
  Hits           3577     3577           
  Misses          628      628           
  Partials        438      438           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@collado-mike
Copy link
Collaborator

Thanks for the fix. Can you sign off on the commit using these instructions? https://github.com/MarquezProject/marquez/pull/2089/checks?check_run_id=8015992113 Once signed off, we'll be happy to merge

Signed-off-by: Michael Barry <github@barry.io>
@jabbera
Copy link
Contributor Author

jabbera commented Aug 25, 2022

@collado-mike all set.

@collado-mike
Copy link
Collaborator

That was fast!

Looks like DCO is still failing because github is expecting a different e-mail address:

Expected "Mike jabbera@users.noreply.github.com", but got "Michael Barry github@barry.io".

Unsure why it has your e-mail address as a github.com address, but...
I can go ahead and mark it as passed and merge it. You might check your github settings so that future commits don't have this issue.

Thanks again for the fix!

@collado-mike collado-mike enabled auto-merge (squash) August 25, 2022 14:28
@wslulciuc wslulciuc disabled auto-merge August 25, 2022 22:31
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jabbera! 💯

@wslulciuc wslulciuc merged commit 07ba426 into MarquezProject:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants