Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix and tests for handling Airflow dags with dots and task groups #2126

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

collado-mike
Copy link
Collaborator

Problem

A recent change broke how marquez handles DAGs with dots and tasks within task groups. This change corrects that and adds a few test cases to validate

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Michael Collado <collado.mike@gmail.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #2126 (f82331e) into main (9bb877d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2126      +/-   ##
============================================
+ Coverage     75.28%   75.30%   +0.02%     
- Complexity     1036     1038       +2     
============================================
  Files           203      203              
  Lines          4879     4883       +4     
  Branches        398      399       +1     
============================================
+ Hits           3673     3677       +4     
  Misses          763      763              
  Partials        443      443              
Impacted Files Coverage Δ
api/src/main/java/marquez/db/OpenLineageDao.java 95.17% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) September 19, 2022 19:03
@wslulciuc wslulciuc merged commit e61fe48 into main Sep 19, 2022
@wslulciuc wslulciuc deleted the fix/handle_airflow_dags_and_groups branch September 19, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants