Show facets even when dataset has no fields. #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2214 +/- ##
=========================================
Coverage 76.67% 76.67%
Complexity 1144 1144
=========================================
Files 219 219
Lines 5312 5312
Branches 421 421
=========================================
Hits 4073 4073
Misses 764 764
Partials 475 475 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
reviewed
Oct 26, 2022
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Use ternary logic. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
ui/show-facets-when-no-dataset-fields
branch
from
857b87e to
9e7bc52
Compare
|
Great job! Congrats on your first merged pull request in the Marquez project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakub Dardzinski kuba0221@gmail.com
Problem
Facets are not shown in UI when dataset has no fields set.
Closes: #2213
Solution
Change logic in DatasetInfo component to always show facets.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)