Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm Ingress template to be cross-compatible with recent k8s versions #2275

Merged

Conversation

jlukenoff
Copy link
Contributor

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: #2274

Solution

Certain components of the Ingress schema have changed in recent versions of Kubernetes. This PR updates the Ingress helm template to render based on the semantic kubernetes version.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
@boring-cyborg boring-cyborg bot added the chart label Dec 2, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 2, 2022

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@jlukenoff jlukenoff changed the title Feat/k8s ingress cross compatibility Update helm Ingress template to be cross-compatible with recent k8s versions Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #2275 (c5239cb) into main (a346e0a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2275   +/-   ##
=========================================
  Coverage     76.84%   76.84%           
  Complexity     1154     1154           
=========================================
  Files           220      220           
  Lines          5268     5268           
  Branches        423      423           
=========================================
  Hits           4048     4048           
  Misses          747      747           
  Partials        473      473           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @jlukenoff! 💯 🥇

FYI, would be great to have version checks for other templates within our chart as well (vs hardcoding them).

@wslulciuc wslulciuc merged commit 4e67d5a into MarquezProject:main Dec 5, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 5, 2022

Great job! Congrats on your first merged pull request in the Marquez project!

@jlukenoff jlukenoff deleted the feat/k8s-ingress-cross-compatibility branch December 5, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart Ingress template incompatible with k8s < v1.18
2 participants