Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw link to iconSearchArrow.svg #2280

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

wslulciuc
Copy link
Member

Problem

The iconSearchArrow.svg fails to load for relative path in nav bar.

Solution

Add direct link to iconSearchArrow.svg similar to #2212

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the web label Dec 5, 2022
@wslulciuc wslulciuc requested a review from phixMe December 5, 2022 12:22
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #2280 (12002c7) into main (0995b0a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2280   +/-   ##
=========================================
  Coverage     76.84%   76.84%           
  Complexity     1154     1154           
=========================================
  Files           220      220           
  Lines          5268     5268           
  Branches        423      423           
=========================================
  Hits           4048     4048           
  Misses          747      747           
  Partials        473      473           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc added the review Ready for review label Dec 5, 2022
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wslulciuc

@wslulciuc wslulciuc enabled auto-merge (squash) December 6, 2022 11:45
@wslulciuc wslulciuc disabled auto-merge December 6, 2022 11:51
@wslulciuc wslulciuc merged commit 2ffb8e0 into main Dec 6, 2022
@wslulciuc wslulciuc deleted the bug/fix-event-viewer-icon branch December 6, 2022 11:51
@wslulciuc wslulciuc restored the bug/fix-event-viewer-icon branch December 13, 2022 17:04
@wslulciuc wslulciuc deleted the bug/fix-event-viewer-icon branch December 13, 2022 17:04
@wslulciuc wslulciuc removed the review Ready for review label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants