Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop view before modifying table fields #2313

Closed
wants to merge 1 commit into from
Closed

drop view before modifying table fields #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*In case of JSON processing exceptions Marquez API should return exception message to a client.*
* Fix column lineage when multiple jobs write to same dataset [`#2289`](https://github.com/MarquezProject/marquez/pull/2289) [@pawel-big-lebowski](https://github.com/pawel-big-lebowski)
*The fix deprecates the way fields `transformationDescription` and `transformationType` are returned. The depracated way of returning those fields will be removed in 0.30.0.*
* Fix `V52` migration [`#2313`](https://github.com/MarquezProject/marquez/pull/2313) [@pawel-big-lebowski](https://github.com/pawel-big-lebowski)

## [0.28.0](https://github.com/MarquezProject/marquez/compare/0.27.0...0.28.0) - 2022-11-21

Expand Down
1 change: 1 addition & 0 deletions api/src/main/resources/marquez/db/migration/V52__alter_dataset_symlinks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/* SPDX-License-Identifier: Apache-2.0 */
DROP VIEW IF EXISTS datasets_view;
Copy link
Collaborator Author

@pawel-big-lebowski pawel-big-lebowski Dec 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://flywaydb.org/documentation/concepts/migrations.html#repeatable-migrations

Repeatable migrations have a description and a checksum, but no version. Instead of being run just once, they are (re-)applied every time their checksum changes.

Within a single migration run, repeatable migrations are always applied last, after all pending versioned migrations have been executed. Repeatable migrations are applied in the order of their description.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the doc says, they are (re-)applied every time their checksum changes. Just dropping the view will not create a view again and the application will break.

ALTER TABLE dataset_symlinks ALTER COLUMN name TYPE VARCHAR;