Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Facet View Enhancement #2336

Merged
merged 20 commits into from
Feb 16, 2023
Merged

UI: Facet View Enhancement #2336

merged 20 commits into from
Feb 16, 2023

Conversation

tito12
Copy link
Contributor

@tito12 tito12 commented Dec 22, 2022

Problem

Now facets are just simple printed JSON, without ability to search, navigate and click on links.
Related to task #2165

Solution

Created dynamic component basen on forked solution and extended, with ability to search through json and navigate easy, expand data and ability to click links.

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

…rmation about license

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@wslulciuc
Copy link
Member

Created dynamic component basen on forked solution and extended

@tito12, can you provide some background as to why we are forking react-json-view?

@tito12
Copy link
Contributor Author

tito12 commented Jan 2, 2023

Created dynamic component basen on forked solution and extended

@tito12, can you provide some background as to why we are forking react-json-view?

This package has most of functions which we need but not all, and specifically this one suit better for our requirements. There are no solution with all of these functionality and it not make sense to create solution like this package from scratch.

@phixMe
Copy link
Member

phixMe commented Jan 3, 2023

I'd really prefer a solution here that doesn't fork a repo. What does this look like if we just use the library out of the box entirely?

@tito12
Copy link
Contributor Author

tito12 commented Jan 4, 2023

I'd really prefer a solution here that doesn't fork a repo. What does this look like if we just use the library out of the box entirely?

This package not contain search functionality and clickable links, which is important due task requirments.
One if idea is to use patch-package, maybe it could be more clean from code side, what do you think?

tito12 added 4 commits January 9, 2023 19:12
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
… patch-package unused logic

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12
Copy link
Contributor Author

tito12 commented Feb 7, 2023

@phixMe please take a look, I linked github repo with fork as we discussed. Thanks!

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #2336 (865e221) into main (0e434d5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2336   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity     1234     1234           
=========================================
  Files           228      228           
  Lines          5572     5572           
  Branches        447      447           
=========================================
  Hits           4297     4297           
  Misses          775      775           
  Partials        500      500           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tito12
Copy link
Contributor Author

tito12 commented Feb 9, 2023

@phixMe please review :)

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here.

web/.eslintignore Outdated Show resolved Hide resolved
web/Dockerfile Outdated Show resolved Hide resolved
web/src/components/jobs/RunInfo.tsx Show resolved Hide resolved
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks amazing.

Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12 tito12 merged commit 56fa342 into main Feb 16, 2023
@tito12 tito12 deleted the jsonview branch February 16, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants