-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Facet View Enhancement #2336
Conversation
…rmation about license Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12, can you provide some background as to why we are forking |
This package has most of functions which we need but not all, and specifically this one suit better for our requirements. There are no solution with all of these functionality and it not make sense to create solution like this package from scratch. |
I'd really prefer a solution here that doesn't fork a repo. What does this look like if we just use the library out of the box entirely? |
This package not contain search functionality and clickable links, which is important due task requirments. |
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
… patch-package unused logic Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@phixMe please take a look, I linked github repo with fork as we discussed. Thanks! |
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
…hub" This reverts commit 8c5eab2.
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2336 +/- ##
=========================================
Coverage 77.11% 77.11%
Complexity 1234 1234
=========================================
Files 228 228
Lines 5572 5572
Branches 447 447
=========================================
Hits 4297 4297
Misses 775 775
Partials 500 500 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@phixMe please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments here.
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks amazing.
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Problem
Now facets are just simple printed JSON, without ability to search, navigate and click on links.
Related to task #2165
Solution
Created dynamic component basen on forked solution and extended, with ability to search through json and navigate easy, expand data and ability to click links.
Checklist
CHANGELOG.md
with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sql
database schema migration according to Flyway's naming convention (if relevant)